Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for URLs with non-default ports #173

Merged
merged 5 commits into from
Sep 4, 2020
+27 −2
Merged

Add support for URLs with non-default ports #173

Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e416b0a
Add support for URLs with non-default ports
jsejcksn Sep 1, 2020
8126255
Format with Prettier
jsejcksn Sep 1, 2020
d260b09
Add tests
jsejcksn Sep 4, 2020
df3a669
fix test
lucacasonato Sep 4, 2020
644b7dd
Update core/deno_cache.ts
lucacasonato Sep 4, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion core/module_resolver.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ export class ModuleResolver implements ModuleResolverInterface {
const originDir = path.join(
getDenoDepsDir(),
url.protocol.replace(/:$/, ""), // https: -> https
url.hostname
`${url.hostname}${url.port ? `_PORT${url.port}` : ""}` // hostname.xyz:3000 -> hostname.xyz_PORT3000
jsejcksn marked this conversation as resolved.
Show resolved Hide resolved
);

const hash = hashURL(url);
Expand Down