Add support for URLs with non-default ports #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axetroy
suggested changes
Sep 1, 2020
- default port (https://example.com:443) - non-default port (http://localhost:3000)
jsejcksn
commented
Sep 4, 2020
Co-authored-by: Jesse Jackson <jsejcksn@users.noreply.github.com>
|
It looks like the test is passing now. Let me know if any other changes are needed. Thanks for both the info and help, @lucacasonato! |
axetroy
pushed a commit
to axetroy/vscode_deno
that referenced
this pull request
Sep 5, 2020
Co-authored-by: Luca Casonato <lucacasonato@yahoo.com>
CGQAQ
pushed a commit
to CGQAQ/vscode_deno
that referenced
this pull request
Sep 13, 2020
Co-authored-by: Luca Casonato <lucacasonato@yahoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref. Deno source: https://github.com/denoland/deno/blob/2da084058397efd6f517ba98c9882760ec0a7bd6/cli/disk_cache.rs#L55
Ref. previous PR: justjavac/typescript-deno-plugin#63
This adds support for port numbers in remote module resolution. I didn't see any places that would support a test for this, so please test with a local file server before merging.
I think this should resolve #171.