This repository has been archived by the owner on Sep 4, 2020. It is now read-only.
Add support for URLs with non-default ports #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justjavac
approved these changes
Jun 30, 2020
@justjavac Did it work as expected? |
|
@justjavac I'd love to get the functionality of this commit in denoland/vscode_deno. What is needed for that? A new release? I saw that the |
|
@jsejcksn Sorry to keep you waiting, I will merge it into vscode_deno in the next few days |
This was referenced Sep 1, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref. Deno source: https://github.com/denoland/deno/blob/2da084058397efd6f517ba98c9882760ec0a7bd6/cli/disk_cache.rs#L55
This adds support for port numbers in remote module resolution. I didn't see any places that would support a test for this, so please test with a local file server before merging.
I think this should resolve denoland/vscode_deno#24 (comment).