-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix README typos, remove next-specific data attributes for components #801
Conversation
@@ -45,7 +45,6 @@ describe('<CollapsiblePanel> with valid data', () => { | |||
|
|||
test('renders <CollapsiblePanel /> with first panel initially expanded', () => { | |||
render(<CollapsiblePanel {...data} startExpanded={true} />) | |||
const vaAccordion = document.querySelector('va-accordion') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not used in this code block so I removed it.
@randimays Should the package.json be brought up to what it is in vets-website if using the current breakpoints stuff?
Or were they functional in the current ones? |
7d5d29b
to
c5a40dc
Compare
@eselkin Great callout. I just double checked and they both work, but notably the now-deprecated version isn't applying correctly so we are benefiting from this either way. Screenshots below were taken at 1201px browser width, which is the DST breakpoint for BeforeAfter |
@timcosgrove Updated the changes to remove the |
@timcosgrove Bumping for your review when you get a chance please! |
@timcosgrove Bumping for your review please :) |
Description
Removes
data-next-component
attributes from components that have them as we won't be needing this data in the markup. This also includes updates to the design system breakpoints that have been done in content-build and vets-website. Some of this code predates those changes so I applied them in this PR. There should be no functionality changes; it's only a name change.Ticket
Relates to department-of-veterans-affairs/va.gov-cms#19386
Developer Task
Tasks