Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BLOCKED] [NextBuild] Migrate the R&S Checklist content type to NextBuild #19386

Open
4 tasks
FranECross opened this issue Oct 2, 2024 · 10 comments
Open
4 tasks
Assignees
Labels
Accelerated Publishing Blocked Issues that are blocked on factors other than blocking issues. current sprint points-8 Public Websites Scrum team in the Sitewide crew sitewide VA.gov frontend CMS team practice area

Comments

@FranECross
Copy link

FranECross commented Oct 2, 2024

Description

The first product feature to be implemented using NextBuild is the Resources & Support content type of Checklist.

The AP team doesn't have capacity at this time to provide focused time or information, so this ticket is for one PW engineer to choose a PW feature to migrate to NextBuild.

The work encompassed in this ticket will entail exploration and laying a lot of groundwork. Given that templates can share common pieces (such as paragraph types), we might end up with duplicate work, but maybe engineers could pick ones that don't have any overlap, if possible.

Note the addition of a QuickStart guide link below in the Artifacts section.

Background

User Story or Problem Statement

As a Sitewide engineer, I want my work to use the latest technology and fastest build system, for maximum efficiency and Veteran value.

As a VA Product Owner, I want my technical products to adopt Accelerated Publishing, to move toward deprecation of content-build as soon as possible.

As an Editor, I want my content changes to be published as quickly as possible, for maximum Veteran access to the latest correct information.

Status / Change management stakeholders

Each Sitewide product will require migration to new templates. Editors who create content in these types will require change management to be aware when the changes are deploying and of the change in behavior for publishing timelines.

Stakeholder / Editor groups are listed below for visibliity, but each group may require its own sub-epic and change management.

Engineering notes / background

Artifacts from Accelerated Publishing Team (in Github)

Analytics considerations

Quality / testing notes

Laura happy to help with QA / verification.

Acceptance criteria

  • Explore and lay groundwork for migration of R&S Checklist content type to NextBuild
  • Create additional tickets as needed
  • Accessibility review if applicable
  • (?) once we know if we can go to prod, define the final ACs for ticket closure - @FranECross
@FranECross FranECross added VA.gov frontend CMS team practice area Accelerated Publishing Public Websites Scrum team in the Sitewide crew Needs refining Issue status labels Oct 2, 2024
@jilladams jilladams changed the title [NextBuild] Migrate the [insert chosen feature] to NextBuild [NextBuild] Migrate the R&S Checklist content type to NextBuild Oct 2, 2024
@jilladams jilladams assigned randimays and unassigned jv-agile6 Oct 2, 2024
@jilladams jilladams removed the Needs refining Issue status label Oct 2, 2024
@randimays
Copy link
Contributor

I have a meeting with Tim this afternoon to work through the remaining Typescript issues I'm having with the project. Those errors may be the reason the web components aren't working correctly (as they cause problems with the build). I believe the TS issues are the last big hurdle to getting this wrapped up.

@randimays
Copy link
Contributor

End-of-sprint update: The dev work for this is complete as far as I can tell, and I'm working on getting CI to pass in order for it to be ready to code review. Not sure when the code can be merged / this ticket can close, but it won't be my primary focus going forward as long as there aren't any issues to fix while in code review / functional testing.

@randimays
Copy link
Contributor

Another update: I have two PRs in code review for Tim to peek at, so I am done with dev work for now. The first one is admin-y and I pulled out some non-functionality changes from my checklist branch for him to review first.

@randimays
Copy link
Contributor

End-of-sprint update: Still waiting for code review

@randimays
Copy link
Contributor

Update: I poked Tim this week to start looking at the code. He and I are actively discussing ways to break the large PR into smaller pieces, and I'm still struggling with some web component hydration issues that he's looking at. This will be ongoing for at least a few more days, most likely.

@randimays
Copy link
Contributor

@jilladams @FranECross

End of sprint update: I only have one checklist PR remaining. I think the hydration issues with the web components still exist, but I haven't had time to get back to the code and run it again after getting other chunks merged in. Given that the Zenhub -> Github ticket is urgent per the EOY deadline, I'm going to set this aside for now and concentrate on that. This will carry over or we can put it in the backlog if we don't anticipate being able to prioritize this again soon.

@FranECross
Copy link
Author

@jilladams What do you think of punting this back to the backlog, and picking it back up next year when R&S filtering/tagging is implemented?

@randimays
Copy link
Contributor

In an effort to reduce the cognitive load of a giant PR on Tim, I pulled out a lot of little code chunks where things needed to be updated to what is in production (I only did this for things that were used on the checklist template). Those went into a Sitewide-integration branch. I'm working on getting that branch merged to main now that Events has been successfully released to production.

However: I saw in this Slack thread that removing events from content-build caused some 404s so I think Tim will be busy with troubleshooting that for a little bit.

Once the Sitewide-integration branch has been merged in, I can update my stale checklist branch and get back to figuring out what the hydration issues are caused by and hopefully move the rest of the code into main soon.

@jilladams
Copy link
Contributor

Components used in R&S content types beyond checklist are in a separate integration branch PR that @timcosgrove is working through to break into smaller PRs that can merge into main. We think Tim must be the person to do this. This ticket is blocked on the merge of those components, in order for the rest of the work for checklists to merge.

@jilladams jilladams added the Blocked Issues that are blocked on factors other than blocking issues. label Dec 23, 2024
@FranECross FranECross changed the title [NextBuild] Migrate the R&S Checklist content type to NextBuild [BLOCKED] [NextBuild] Migrate the R&S Checklist content type to NextBuild Dec 23, 2024
@jilladams
Copy link
Contributor

Moved to Admin and marked blocked until we get traction on the blockers from AP.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accelerated Publishing Blocked Issues that are blocked on factors other than blocking issues. current sprint points-8 Public Websites Scrum team in the Sitewide crew sitewide VA.gov frontend CMS team practice area
Projects
None yet
Development

No branches or pull requests

4 participants