Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VACMS-19386 Update contact info component #821

Merged
merged 1 commit into from
Nov 25, 2024

Conversation

randimays
Copy link
Contributor

@randimays randimays commented Nov 25, 2024

Description

Updates contact info component to align visually with with what is in production. Updates the names of the properties to make a bit more sense with the structure of the data that's being returned from Drupal.

Ticket

department-of-veterans-affairs/va.gov-cms#19386

Developer Task

Tasks

Preview Give feedback

Testing Steps

This component is used on Resources & Support templates but since there aren't any live yet, it can be tested through storybook.

Screenshots

Storybook for contact info:

Before After
Screenshot 2024-11-25 at 2 16 47 PM Screenshot 2024-11-25 at 2 14 33 PM
Screenshot 2024-11-25 at 2 16 54 PM Screenshot 2024-11-25 at 2 14 40 PM
Screenshot 2024-11-25 at 2 16 59 PM Screenshot 2024-11-25 at 2 14 44 PM

Reviewer

Reviewing a PR

This section lists items that need to be checked or updated when making changes to this repository.

Standard Checks

Tasks

Preview Give feedback

Merging an Approved Layout

When merging a layout, you must ensure that the content type has been turned on for next-build inside the CMS. This CMS flag must be turned on for editors to preview their work using the next build preview server.

Resource types (layouts) that have not been approved by design should NOT be pushed to production. Ensure that slug.tsx does not include your resource type if it is not approved.

The status of layouts should be kept up to date inside templates.md. This includes QA progress, development progress, etc. A link should be provided for where testing can occur.

Merging a Non-Approved Layout

Your new resource type should not be included inside slug.tsx. Items added here will go into production once merged into the main branch. It is imperative that we do not push anything live that has not been approved.

Ensure that this layout has been added to the templates.md file with the current status of the work.

@va-cms-bot va-cms-bot temporarily deployed to Tugboat November 25, 2024 20:16 Destroyed
@randimays randimays marked this pull request as ready for review November 25, 2024 21:06
@randimays randimays merged commit 7ad14c6 into Sitewide-integration Nov 25, 2024
8 checks passed
@randimays randimays deleted the 19386-contact-info branch November 25, 2024 22:41
randimays added a commit that referenced this pull request Dec 12, 2024
randimays added a commit that referenced this pull request Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants