API-24392: Remove test feature from VBADocuments enabled_features c…

…onfig (#12300) * API-24392: Remove test feature from enabled_features config
department-of-veterans-affairs · Mar 30, 2023 · 6c7dd5d · 6c7dd5d
1 parent ca4e64d
commit 6c7dd5d
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/modules/vba_documents/config/flipper/enabled_features.yml b/modules/vba_documents/config/flipper/enabled_features.yml
@@ -1,5 +1,4 @@
 common:
-  - test_feature_flag_alert_temp
 development:
 staging:
 sandbox:

diff --git a/modules/vba_documents/spec/workers/flipper_status_alert_spec.rb b/modules/vba_documents/spec/workers/flipper_status_alert_spec.rb
@@ -91,6 +91,7 @@
     end
 
     it 'does not notify Slack when all features are enabled' do
+      allow(YAML).to receive(:load_file).and_return({ 'common' => %w[feature1 feature2] })
       bulk_checker_result = { enabled: %w[feature1 feature2], disabled: [], missing: [] }
       allow(Flipper::Utilities::BulkFeatureChecker).to receive(:enabled_status).and_return(bulk_checker_result)
       expect(VBADocuments::Slack::Messenger).not_to receive(:new)
@@ -99,6 +100,7 @@
     end
 
     it 'notifies Slack when some features are disabled' do
+      allow(YAML).to receive(:load_file).and_return({ 'common' => %w[feature1 feature2 feature3] })
       bulk_checker_result = { enabled: %w[feature1], disabled: %w[feature2 feature3], missing: [] }
       allow(Flipper::Utilities::BulkFeatureChecker).to receive(:enabled_status).and_return(bulk_checker_result)
       expected_notify = {
@@ -114,6 +116,7 @@
     end
 
     it 'notifies Slack when some features are missing' do
+      allow(YAML).to receive(:load_file).and_return({ 'common' => %w[feature1 feature2 feature3] })
       bulk_checker_result = { enabled: %w[feature1], disabled: [], missing: %w[feature2 feature3] }
       allow(Flipper::Utilities::BulkFeatureChecker).to receive(:enabled_status).and_return(bulk_checker_result)
       expected_notify = {
@@ -129,6 +132,7 @@
     end
 
     it 'notifies slack when there are disabled and missing features' do
+      allow(YAML).to receive(:load_file).and_return({ 'common' => %w[feature1 feature2 feature3 feature4 feature5] })
       bulk_checker_result = { enabled: %w[feature1], disabled: %w[feature2 feature3], missing: %w[feature4 feature5] }
       allow(Flipper::Utilities::BulkFeatureChecker).to receive(:enabled_status).and_return(bulk_checker_result)
       expected_notify = {