Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API-24392: Remove test feature from VBADocuments enabled_features config #12300

Merged

Conversation

kristen-brown
Copy link
Contributor

Summary

The VBADocuments::FlipperStatusAlert job alerts Slack when VBADocuments (Benefits Intake) features that are expected to be enabled are not enabled. A "test" feature flag had previously been added to the config for enabled features to check, to ensure that the feature was working as expected (since there are no active feature flags for VBADocuments currently). The alerting feature has been verified as working as expected, so this PR removes the "test" feature flag from the config.

Related issue(s)

API-24392

Testing done

Unit tests cover the testing well for this one.

Screenshots

None

What areas of the site does it impact?

VBADocuments module only, and specifically the VBADocuments::FlipperStatusAlert job.

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable). – N/A
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution – N/A
  • Documentation has been updated (link to documentation) – N/A
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable) – N/A
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected – N/A
  • I added a screenshot of the developed feature – N/A

Requested Feedback

No specific feedback requested.

@kristen-brown kristen-brown added Lighthouse lighthouse banana-peels Lighthouse Banana Peels Team labels Mar 30, 2023
@kristen-brown kristen-brown requested review from a team as code owners March 30, 2023 20:23
cilestin
cilestin previously approved these changes Mar 30, 2023
@va-vsp-bot va-vsp-bot requested a deployment to master/main/API-24392-remove-test-feature-from-enabled-features-config March 30, 2023 20:42 In progress
@@ -91,6 +91,7 @@
end

it 'does not notify Slack when all features are enabled' do
allow(YAML).to receive(:load_file).and_return({ 'common' => %w[feature1 feature2] })
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I removed the last remaining feature from enabled_features.yml, the "no features found" Slack alert kicked in before the BulkFeatureChecker could be called, leading to test failures.

@cilestin cilestin merged commit 6c7dd5d into master Mar 30, 2023
@cilestin cilestin deleted the API-24392-remove-test-feature-from-enabled-features-config branch March 30, 2023 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
banana-peels Lighthouse Banana Peels Team Lighthouse lighthouse
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants