Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding claimDate to cmp metadata on backup submission #11674

Merged
merged 0 commits into from
Jan 30, 2023

Conversation

kylesoskin
Copy link
Contributor

@kylesoskin kylesoskin commented Jan 30, 2023

Summary

  • Adding a claimDate to backup paper 526 submissions at request of CMP and MAS team
  • This allows them to properly set the DOR

Related issue(s)

department-of-veterans-affairs/va.gov-team#50111

Testing done

local/rspec

What areas of the site does it impact?

backend

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

Copy link

@rbeckwith-oddball rbeckwith-oddball left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ruby syntax-wise, it looks good.

@kylesoskin kylesoskin merged commit f44c56a into master Jan 30, 2023
@kylesoskin kylesoskin deleted the ksoskin/add_claimDate_to_cmp_metadata branch January 30, 2023 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants