Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

526ez | Implement and test 526 backup submissions #50111

Closed
20 tasks done
saderagsdale opened this issue Nov 29, 2022 · 12 comments
Closed
20 tasks done

526ez | Implement and test 526 backup submissions #50111

saderagsdale opened this issue Nov 29, 2022 · 12 comments
Assignees
Labels
526 v 1 and 2 backend bmt-team-1 Benefits Management Tools Team #1 Decision-Reviews-Team (Formerly squad-2) Label for issues being worked on by Decision Reviews on BMT & DR team

Comments

@saderagsdale
Copy link
Contributor

saderagsdale commented Nov 29, 2022

Value Statement

As a veteran with an issue that prevents auto establishment of my 526 claim
I want to be sure that my submission gets to the VA, even if it is not auto-established
So that it does not go into a blackhole without my knowledge


Background Context

Acceptance Criteria

  • Upon final failure, pdf documents are generated
  • Generated Docs are sent to central mail via LH Claims intake API
  • Central Mail receives the items an can action the claim in some way

Designs and Build Notes

  • I have code to do all of this EXCEPT the 526 form generation itself
  • EVSS thinks they can add an endpoint that returns a 526 pdf, from the same data we already submit
  • Need to figure out/ensure that gets prioritized and see how long that will take vs doing our own

Out of scope

  • Add here

Open questions

  • Can EVSS add "return 526 pdf" endpoint, since they already have code that does this anyway? -they can
  • How long will it take?- they did it, it didnt take that long
  • Should we just do one ourselves if it will take a while?- no

Definition of Ready

  • Clear value description
  • Testable acceptance criteria
  • Accessibility added to acceptance criteria
  • Approved designs attached
  • Sample data provided where appropriate
  • Estimated to fit within the sprint
  • Dependencies and blockers linked

Definition of Done

  • Meets acceptance criteria
  • Passed integration testing (if applicable)
  • Code reviewed (internal)
  • Submitted to staging
  • Tested in staging
  • Released in prod
  • Tested via manual submission on real claims in production
  • Verification of validity of claims received from VA
  • Flipper turned on in production
  • Observed for a few days to check logs for any unforeseen errors
@saderagsdale saderagsdale added bmt-team-1 Benefits Management Tools Team #1 526 v 1 and 2 Decision-Reviews-Team (Formerly squad-2) Label for issues being worked on by Decision Reviews on BMT & DR team backend labels Nov 29, 2022
@saderagsdale
Copy link
Contributor Author

Waiting to hear from Michael Harlow/EVSS regarding when there is an endpoint available to return a PDF.

@saderagsdale
Copy link
Contributor Author

Timothy Baker (EVSS dev) is working on the endpoint (reached out to Kyle on 11/30)

@kylesoskin
Copy link
Contributor

Waiting on EVSS to get us the 526 endpoint. The rest is done (will write additional test cases in mean time)

@saderagsdale
Copy link
Contributor Author

EVSS has the staging version of the endpoint ready. Kyle working on the test cases. @mattpointzxer0

@saderagsdale
Copy link
Contributor Author

Waiting for EVSS to share the level of effort to move contentions out of the "overflow" area.

Kyle discovered one potential issue with evidence uploading in additional testing. It seems that non-pdf type evidence(s) are not properly getting attached. Looking into that now before doing the additional 4 prod submissions that we will observe/track.

@saderagsdale
Copy link
Contributor Author

Waiting for EVSS to make date timestamp changes (estimated on 1/25)

@saderagsdale
Copy link
Contributor Author

Merged yesterday, just waiting for EVSS.

@saderagsdale
Copy link
Contributor Author

@kylesoskin Reminder to include the other test cases that Matt raised in our last convo with him.

@kylesoskin
Copy link
Contributor

EVSS staging datastamp fix released. Tested in staging, seems to work as intended.

@kylesoskin
Copy link
Contributor

After discussion with Matt Self previously, we are cranking the retry window down from 15 attempt (~36hrs) to 13 attempts (~24hrs), PR above

@saderagsdale
Copy link
Contributor Author

Future (backup submission path):

  • EVSS releases today (but not until 9pm unfortunately), testing in production of 5 claims (manually, by va.gov) will happen tomorrow morning, I will provide submissions IDs for VA to verify
  • Once confirmed as good submissions we can then either test more manually, for them to also verify, or turn it on to auto-send, or whatever they want
  • va.gov will keep an eye on logs and dashboards for errors after it is decided to be "turned on"

@kylesoskin
Copy link
Contributor

This is released in production, and turned on in the settings.yml. It is awaiting final approval before "going live" via the flipper switch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
526 v 1 and 2 backend bmt-team-1 Benefits Management Tools Team #1 Decision-Reviews-Team (Formerly squad-2) Label for issues being worked on by Decision Reviews on BMT & DR team
Projects
None yet
Development

No branches or pull requests

2 participants