Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with rate limiting and expired applications #11687

Merged
merged 0 commits into from
Feb 1, 2023

Conversation

kylesoskin
Copy link
Contributor

@kylesoskin kylesoskin commented Jan 31, 2023

Summary

  • This adds the option to instantiate a backup submission object without automatically requesting an upload UUID from lighthouse, this eliminates the 429/ratelimit when doing batch processing
  • This also fudges the expiration date to allow a doc to be generated through EVSS, the date is not actually used by them for anything, confirmed by EVSS so fudging it does not effect anything, except lets it go through to PDF generation, which is what we want
  • This is owned by Benefits Team 1 or Decision Review Team
  • no flipper

Related issue(s)

department-of-veterans-affairs/va.gov-team#50111

Testing done

-locally, rspec, will do staging once merged

What areas of the site does it impact?

*backend and sidekiq

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

@kylesoskin kylesoskin merged commit af5c134 into master Feb 1, 2023
@kylesoskin kylesoskin deleted the ksoskin/rate_limiting_fix_and_date_override branch February 1, 2023 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants