Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding 2 extra requirements to the backup submission #11731

Merged
merged 0 commits into from
Feb 6, 2023

Conversation

kylesoskin
Copy link
Contributor

@kylesoskin kylesoskin commented Feb 6, 2023

Summary

  • This adds 2 additional checks before sending a 526 backup submission
    -- It is a overall 526 submission, not an upload job
    -- it does not already have a claim ID (through RRD process?)
  • This avoid duplicate 526 backup submissions
  • Decision Review Team owns it currently, Benefits Experience team will own at some point
  • uses a flipper, that is already flipped on: form526_backup_submission_temp_killswitch

Related issue(s)

department-of-veterans-affairs/va.gov-team#50111

Testing done

  • local testing, existing rspec tests to test backup submission still gets sent

What areas of the site does it impact?

backend, sidekiq

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

@va-vfs-bot va-vfs-bot temporarily deployed to ksoskin/dont_send_backup_if_id_exists/main/main February 6, 2023 14:01 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to ksoskin/dont_send_backup_if_id_exists/main/main February 6, 2023 16:16 Inactive
@kylesoskin kylesoskin marked this pull request as ready for review February 6, 2023 17:37
@kylesoskin kylesoskin requested review from a team as code owners February 6, 2023 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants