API-22858: Add supplemental claim form v3 fields and data (part 1)

[caseywilliams]

Summary

• Adds the new v3 of the Supplemental Claim form to the repo (but not to any APIs yet)
• There are two major differences in this new version, neither of which was deemed significant enough to warrant a new version of the APIs:
  1. The SOC/SSOC Opt-in checkbox has been removed. This is because this option is no longer a choice - all claims will go through this process.
  2. The phone number field has been updated so that instead of a single phone field, there are now fillable domestic phone fields and a free text international phone field. Because there is no fillable field for a phone extension, domestic phone numbers with extensions use the international phone field.
• This PR includes only the configuration of the fillable form fields and text boxes, plus the data to fill those fields. The process of filling the form is shown in my old PR API-22858: Update Supplemental Claims form from v2 to v3 #11863, but I had to split it into two (this being the first part) so as not to exceed the line limit.

Related issue(s)

• API-22858
• API-22858: Update Supplemental Claims form from v2 to v3 #11863 was my initial PR for this work (closed for being too large, but you can see the structure of the form to come in my next PR there)

Testing done

• Added test cases based on the previous version of the form
• Added test cases for new behavior around phone numbers

What areas of the site does it impact?

None yet

Acceptance criteria

• I fixed|updated|added unit tests and integration tests for each feature (if applicable).
• No error nor warning in the console.
• Events are being sent to the appropriate logging solution
• Documentation has been updated (link to documentation)
• No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
• Feature/bug has a monitor built into Datadog or Grafana (if applicable)
• If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
• I added a screenshot of the developed feature

[github-actions]

1 Warning

⚠️

This PR changes 445 LoC (not counting whitespace/newlines). In order to ensure each PR receives the proper attention it deserves, we recommend not exceeding 200. Expect some delays getting reviews. File Summary Files modules/appeals_api/app/models/appeals_api/appellant.rb (+1/-1) modules/appeals_api/app/services/appeals_api/pdf_construction/supplemental_claim/v3/form_data.rb (+191/-0) modules/appeals_api/app/services/appeals_api/pdf_construction/supplemental_claim/v3/form_fields.rb (+74/-0) modules/appeals_api/spec/services/appeals_api/pdf_construction/supplemental_claim/v3/form_data_spec.rb (+157/-0) modules/appeals_api/spec/services/appeals_api/pdf_construction/supplemental_claim/v3/form_fields_spec.rb (+21/-0) Note: We exclude files matching the following when considering PR size: *.csv, *.json, *.tsv, *.txt, Gemfile.lock, app/swagger, modules/mobile/docs, spec/fixtures/, spec/support/vcr_cassettes/, modules/mobile/spec/support/vcr_cassettes/, db/seeds, modules/vaos/app/docs, modules/meb_api/app/docs, modules/appeals_api/app/swagger/ Big PRs are difficult to review, often become stale, and cause delays.

Generated by 🚫 Danger

[caseywilliams]

I'm not sure it's correct to change this here, but I noticed that this would consider phone numbers without an explicit country code to be international.

This test case fails if this change isn't made - I could fix this in the FormData logic instead, but I thought I'd try here first. Happy to update if this change seems too risky (or if this is actually the intended behavior)

[caseywilliams]

These data getters for phones and signatures return nil when they should not be used, even if data is technically available - I found that this helped avoid putting some logic in the form structure code (see my older PR linked in the description)

[caseywilliams]

The only reason this isn't failing tests by referring to the Strucure is that I don't have tests for boxes - this value will come in my next PR - see how that will look in my original PR here, which was closed for being too long