Make Supplemental Claim form v3 available

[caseywilliams]

Summary

• This is a follow-up to API-22858: Add supplemental claim form v3 fields and data (part 1) #11866 - it adds structure for the new supplemental claims PDF and gates its use behind a new Flipper flag, decision_review_supplemental_claim_pdf_v3
  • Once we've confirmed it's ok to start using this new form by default, we can remove this flag, too
• Changes in this new version of the PDF:
  • SOC/SSOC checkbox is removed (because you cannot opt out going forward)
  • Domestic phone number gets its own fillable fields, a separate free text international phone field is added, and the email field gets bigger; spacing is tightened on the first page of the the form to accommodate this: for example, there is one fewer row in the issues table on the first page
• Other updates I made vs. v2 of this form:
  • In the new form, there is no space for a phone extension in the domestic phone fields, so if the phone number has an extension, it's filled in the international field instead of the domestic fields.
  • In v2, the name of the alternate signer (below the signature) was never filled out. It's easy to read the name from the typed signature, so this doesn't seem like it was a big deal. However, I found this method in the form data for v2 - it is unused, but it seemed like it might have been intended for this purpose and just never been filled in, so I filled in this field for v3.
  • In v2, whenever an extra page was added for data overflows (for signatures, extra issues, etc.), the table headings would be printed every time, even if there was no data to put in the tables. In the new v3 I omitted the tables where there was no data.

Related issue(s)

• API-22858

Testing done

• Added test cases based on v2 of the form + new ones for new phone behavior

What areas of the site does it impact?

Adds a new Flipper flag, decision_review_supplemental_claim_pdf_v3, which will cause the Supplemental Claims API v0 and the Decision Reviews API v2 to start using v3 of the the Supplemental Claim form PDF when submitting a claim. Behavior will not change until this flag is flipped.

Acceptance criteria

• I fixed|updated|added unit tests and integration tests for each feature (if applicable).
• No error nor warning in the console.
• Events are being sent to the appropriate logging solution
• Documentation has been updated (link to documentation)
• No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
• Feature/bug has a monitor built into Datadog or Grafana (if applicable)
• If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
• I added a screenshot of the developed feature

[github-actions]

1 Warning

⚠️

This PR changes 500 LoC (not counting whitespace/newlines). In order to ensure each PR receives the proper attention it deserves, we recommend not exceeding 200. Expect some delays getting reviews. File Summary Files config/features.yml (+3/-0) modules/appeals_api/app/controllers/appeals_api/v2/decision_reviews/supplemental_claims_controller.rb (+1/-1) modules/appeals_api/app/services/appeals_api/pdf_construction/supplemental_claim/v3/form_data.rb (+4/-4) modules/appeals_api/app/services/appeals_api/pdf_construction/supplemental_claim/v3/form_fields.rb (+29/-16) modules/appeals_api/app/services/appeals_api/pdf_construction/supplemental_claim/v3/pages/additional_pages.rb (+73/-0) modules/appeals_api/app/services/appeals_api/pdf_construction/supplemental_claim/v3/structure.rb (+172/-0) modules/appeals_api/spec/services/appeals_api/pdf_construction/generator_spec.rb (+76/-52) modules/appeals_api/spec/services/appeals_api/pdf_construction/supplemental_claim/v3/form_data_spec.rb (+4/-15) modules/appeals_api/spec/services/appeals_api/pdf_construction/supplemental_claim/v3/structure_spec.rb (+50/-0) Note: We exclude files matching the following when considering PR size: *.csv, *.json, *.tsv, *.txt, Gemfile.lock, app/swagger, modules/mobile/docs, spec/fixtures/, spec/support/vcr_cassettes/, modules/mobile/spec/support/vcr_cassettes/, db/seeds, modules/vaos/app/docs, modules/meb_api/app/docs, modules/appeals_api/app/swagger/ Big PRs are difficult to review, often become stale, and cause delays.

Generated by 🚫 Danger

[caseywilliams]

I realized I made some copy/paste typos in the data and fields in my last PR 😬 - these are fixes for that (and a few adjustments to make free text fields fill their boxes better)