Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ruby 3 KwArgs: Fix PreCheckInsRequest Spec #12031

Merged
merged 0 commits into from
Mar 9, 2023

Conversation

ericboehs
Copy link
Contributor

@ericboehs ericboehs commented Mar 9, 2023

Ruby 2.7 deprecated automatic casting of a hash passed as the last argument of a method to keyword arguments. You must now use actual keyword arguments (foo(bar: 'baz') instead of foo({bar: 'baz'})) or cast the hash to keyword args using the double splat (foo(**{bar: 'baz'})).

In preparation for upgrading to Ruby 3.0, we're implementing the new syntax for V2::PreCheckInsController spec.

Fix test:

rspec "./modules/check_in/spec/request/v2/pre_check_ins_request_spec.rb"

Pulled from: department-of-veterans-affairs/va.gov-team#54796

@ericboehs ericboehs merged commit 4aaf78d into master Mar 9, 2023
@ericboehs ericboehs deleted the eb-r3k-pre-check-in-request-spec branch March 9, 2023 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants