Ruby 3 Spec: Wrong number of arguments (233) #54796
Assignees
Labels
Comments
36 tasks
ericboehs
changed the title
ericboehs
added a commit
to department-of-veterans-affairs/vets-api
that referenced
this issue
Mar 9, 2023
Ruby 2.7 deprecated automatic casting of a hash passed as the last argument of a method to keyword arguments. You must now use actual keyword arguments (`foo(bar: 'baz')` instead of `foo({bar: 'baz'})`) or cast the hash to keyword args using the double splat (`foo(**{bar: 'baz'})`).
In preparation for upgrading to Ruby 3.0, we're implementing the new syntax for Vaos Logging spec.
Pulled from: department-of-veterans-affairs/va.gov-team#54796
This was referenced Mar 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
These specs are failing on the
ruby-3-0branch:To fix the following - department-of-veterans-affairs/vets-api#12086
To fix the following - department-of-veterans-affairs/vets-api#12084
rspec "./modules/check_in/spec/request/v0/travel_claims_request_spec.rb[1:1:3:1:1]" # L86rspec "./modules/check_in/spec/request/v0/travel_claims_request_spec.rb[1:1:3:4:1]" # L158rspec "./modules/check_in/spec/request/v0/travel_claims_request_spec.rb[1:1:3:6:1]" # L206rspec "./modules/check_in/spec/request/v0/travel_claims_request_spec.rb[1:1:3:5:1]" # L182rspec "./modules/check_in/spec/request/v0/travel_claims_request_spec.rb[1:1:3:2:1]" # L110rspec "./modules/check_in/spec/request/v0/travel_claims_request_spec.rb[1:1:3:3:1]" # L134To fix the following - department-of-veterans-affairs/vets-api#12082
rspec "./modules/appeals_api/spec/services/appeals_api/pdf_construction/supplemental_claim/v2/structure_spec.rb[1:2:1]" # L21rspec "./modules/appeals_api/spec/workers/higher_level_review_upload_status_updater_spec.rb[1:2:2]" # L38rspec "./modules/appeals_api/spec/serializers/evidence_submission_serializer_spec.rb[1:7:3]" # L58rspec "./modules/appeals_api/spec/serializers/evidence_submission_serializer_spec.rb[1:7:1]" # L50rspec "./modules/appeals_api/spec/serializers/evidence_submission_serializer_spec.rb[1:7:2]" # L54rspec "./modules/appeals_api/spec/services/appeals_api/pdf_construction/supplemental_claim/v3/structure_spec.rb[1:2:1]" # L21rspec "./modules/appeals_api/spec/mailers/decision_review_mailer_spec.rb[1:1:4]" # L47rspec "./modules/appeals_api/spec/services/appeals_api/pdf_construction/generator_spec.rb[1:1:3:1:1:1]" # L124rspec "./modules/appeals_api/spec/services/appeals_api/pdf_construction/generator_spec.rb[1:1:3:1:3:1]" # L148rspec "./modules/appeals_api/spec/services/appeals_api/pdf_construction/generator_spec.rb[1:1:3:1:2:1]" # L136rspec "./modules/appeals_api/spec/services/appeals_api/pdf_construction/generator_spec.rb[1:1:3:1:5:1]" # L185rspec "./modules/appeals_api/spec/services/appeals_api/pdf_construction/generator_spec.rb[1:1:3:1:4:2]" # L168rspec "./modules/appeals_api/spec/services/appeals_api/pdf_construction/generator_spec.rb[1:1:3:1:4:1]" # L158rspec "./modules/appeals_api/spec/services/appeals_api/pdf_construction/generator_spec.rb[1:1:4:2:1]" # L230rspec "./modules/appeals_api/spec/services/appeals_api/pdf_construction/generator_spec.rb[1:1:4:2:4:1]" # L276rspec "./modules/appeals_api/spec/services/appeals_api/pdf_construction/generator_spec.rb[1:1:4:2:5:1]" # L308rspec "./modules/appeals_api/spec/services/appeals_api/pdf_construction/generator_spec.rb[1:1:4:2:3:1]" # L267rspec "./modules/appeals_api/spec/services/appeals_api/pdf_construction/generator_spec.rb[1:1:4:2:2:1]" # L248rspec "./modules/appeals_api/spec/services/appeals_api/pdf_construction/generator_spec.rb[1:1:4:1:1]" # L230rspec "./modules/appeals_api/spec/services/appeals_api/pdf_construction/generator_spec.rb[1:1:4:1:4:1]" # L276rspec "./modules/appeals_api/spec/services/appeals_api/pdf_construction/generator_spec.rb[1:1:4:1:2:1]" # L248rspec "./modules/appeals_api/spec/services/appeals_api/pdf_construction/generator_spec.rb[1:1:4:1:3:1]" # L267rspec "./modules/appeals_api/spec/services/appeals_api/pdf_construction/generator_spec.rb[1:1:4:1:5:1]" # L308rspec "./modules/appeals_api/spec/lib/decision_review_report_spec.rb[1:13:2:2:1]" # L306rspec "./modules/appeals_api/spec/lib/decision_review_report_spec.rb[1:13:2:2:2]" # L312rspec "./modules/appeals_api/spec/lib/decision_review_report_spec.rb[1:13:1:2:2]" # L252rspec "./modules/appeals_api/spec/lib/decision_review_report_spec.rb[1:13:1:2:1]" # L247rspec "./modules/appeals_api/spec/models/notice_of_disagreement_spec.rb[1:16:1:1:1:1:1]" # L20rspec "./modules/appeals_api/spec/models/notice_of_disagreement_spec.rb[1:16:1:1:2:1:1]" # L40rspec "./modules/appeals_api/spec/models/notice_of_disagreement_spec.rb[1:16:1:1:3:1:1]" # L58rspec "./modules/appeals_api/spec/models/supplemental_claim_spec.rb[1:2:1:2:1:1]" # L40rspec "./modules/appeals_api/spec/models/supplemental_claim_spec.rb[1:2:1:1:1:1]" # L20rspec "./modules/appeals_api/spec/models/supplemental_claim_spec.rb[1:2:3:1]" # L50To fix the following - department-of-veterans-affairs/vets-api#12074
rspec "./modules/check_in/spec/request/v2/sessions_request_spec.rb[1:2:2:1]" # L248rspec "./modules/check_in/spec/request/v2/sessions_request_spec.rb[1:2:3:1]" # L278rspec "./modules/check_in/spec/request/v2/sessions_request_spec.rb[1:2:4:1:1:2]" # L336rspec "./modules/check_in/spec/request/v2/sessions_request_spec.rb[1:2:4:1:1:1]" # L327rspec "./modules/check_in/spec/request/v2/sessions_request_spec.rb[1:2:4:1:2:3]" # L387rspec "./modules/check_in/spec/request/v2/sessions_request_spec.rb[1:2:4:1:2:2]" # L374rspec "./modules/check_in/spec/request/v2/sessions_request_spec.rb[1:2:4:1:2:1]" # L361rspec "./modules/check_in/spec/request/v2/sessions_request_spec.rb[1:2:1:1]" # L227rspec "./modules/check_in/spec/request/v2/sessions_request_spec.rb[1:2:5:2:1]" # L434rspec "./modules/check_in/spec/request/v2/sessions_request_spec.rb[1:2:5:3:1]" # L450rspec "./modules/check_in/spec/request/v2/sessions_request_spec.rb[1:2:5:1:1]" # L418rspec "./modules/check_in/spec/request/v2/sessions_request_spec.rb[1:1:3:1]" # L84The following tests are passing now and didn't require any changes (fixing something else fixed these):
rspec "./modules/vba_documents/spec/workers/slack_notifier_spec.rb[1:5]" # L126rspec "./modules/vba_documents/spec/workers/slack_notifier_spec.rb[1:3:2]" # L78rspec "./modules/vba_documents/spec/workers/slack_notifier_spec.rb[1:3:1]" # L72rspec "./modules/vba_documents/spec/workers/slack_notifier_spec.rb[1:4:1]" # L104rspec "./modules/vba_documents/spec/workers/slack_notifier_spec.rb[1:4:2]" # L110rspec "./modules/vba_documents/spec/models/upload_submission_spec.rb[1:4:1]" # L411rspec "./modules/vba_documents/spec/models/upload_submission_spec.rb[1:4:2]" # L434rspec "./modules/vba_documents/spec/models/upload_submission_spec.rb[1:3:18]" # L313rspec "./modules/vba_documents/spec/models/upload_submission_spec.rb[1:3:17]" # L304rspec "./modules/vba_documents/spec/models/upload_submission_spec.rb[1:3:13]" # L274rspec "./modules/vba_documents/spec/models/upload_submission_spec.rb[1:3:10]" # L247rspec "./modules/vba_documents/spec/models/upload_submission_spec.rb[1:3:4]" # L168rspec "./modules/vba_documents/spec/models/upload_submission_spec.rb[1:3:11]" # L258rspec "./modules/vba_documents/spec/models/upload_submission_spec.rb[1:3:9]" # L238rspec "./modules/vba_documents/spec/models/upload_submission_spec.rb[1:3:19]" # L322rspec "./modules/vba_documents/spec/models/upload_submission_spec.rb[1:3:15]" # L284rspec "./modules/vba_documents/spec/models/upload_submission_spec.rb[1:3:5]" # L180rspec "./modules/vba_documents/spec/models/upload_submission_spec.rb[1:3:1]" # L141rspec "./modules/vba_documents/spec/models/upload_submission_spec.rb[1:3:14]" # L279rspec "./modules/vba_documents/spec/models/upload_submission_spec.rb[1:3:6]" # L191rspec "./modules/vba_documents/spec/models/upload_submission_spec.rb[1:3:8]" # L215rspec "./modules/vba_documents/spec/models/upload_submission_spec.rb[1:3:7]" # L205rspec "./modules/vba_documents/spec/models/upload_submission_spec.rb[1:3:3]" # L159rspec "./modules/vba_documents/spec/models/upload_submission_spec.rb[1:3:23]" # L387rspec "./modules/vba_documents/spec/models/upload_submission_spec.rb[1:3:2]" # L150rspec "./modules/vba_documents/spec/models/upload_submission_spec.rb[1:3:21]" # L362rspec "./modules/vba_documents/spec/models/upload_submission_spec.rb[1:3:22]" # L373rspec "./modules/vba_documents/spec/models/upload_submission_spec.rb[1:3:16]" # L294rspec "./modules/vba_documents/spec/models/upload_submission_spec.rb[1:3:20:1]" # L347rspec "./modules/vba_documents/spec/models/upload_submission_spec.rb[1:1:4]" # L117rspec "./modules/vba_documents/spec/models/upload_submission_spec.rb[1:1:2]" # L107rspec "./modules/vba_documents/spec/models/upload_submission_spec.rb[1:1:5]" # L122rspec "./modules/vba_documents/spec/models/upload_submission_spec.rb[1:1:3]" # L112rspec "./modules/vba_documents/spec/models/upload_submission_spec.rb[1:1:1]" # L95rspec "./modules/appeals_api/spec/models/higher_level_review_spec.rb[1:21:1:1:1:1]" # L20rspec "./modules/appeals_api/spec/models/higher_level_review_spec.rb[1:21:1:2:1:1]" # L40rspec "./modules/appeals_api/spec/models/higher_level_review_spec.rb[1:21:1:3:1:1]" # L58rspec "./modules/vba_documents/spec/models/upload_file_spec.rb[1:1]" # L9rspec "./modules/vba_documents/spec/request/v1/uploads_request_spec.rb[1:2:7]" # L178rspec "./modules/vba_documents/spec/request/v1/uploads_request_spec.rb[1:2:8:1]" # L188rspec "./modules/vba_documents/spec/request/v1/uploads_request_spec.rb[1:2:3:1]" # L85rspec "./modules/vba_documents/spec/request/v1/uploads_request_spec.rb[1:2:3:2]" # L93rspec "./modules/vba_documents/spec/request/v1/uploads_request_spec.rb[1:2:6:2]" # L168rspec "./modules/vba_documents/spec/request/v1/uploads_request_spec.rb[1:2:6:1]" # L155rspec "./modules/vba_documents/spec/request/v1/uploads_request_spec.rb[1:2:4:2]" # L115rspec "./modules/vba_documents/spec/request/v1/uploads_request_spec.rb[1:2:4:1]" # L107rspec "./modules/vba_documents/spec/request/v1/uploads_request_spec.rb[1:2:9:1]" # L197rspec "./modules/vba_documents/spec/workers/upload_processor_spec.rb[1:1:13]" # L266rspec "./modules/vba_documents/spec/workers/upload_processor_spec.rb[1:1:8]" # L253rspec "./modules/vba_documents/spec/workers/upload_processor_spec.rb[1:1:30]" # L428rspec "./modules/vba_documents/spec/workers/upload_processor_spec.rb[1:1:17]" # L303rspec "./modules/vba_documents/spec/workers/upload_processor_spec.rb[1:1:26]" # L387rspec "./modules/vba_documents/spec/workers/upload_processor_spec.rb[1:1:14]" # L266rspec "./modules/vba_documents/spec/workers/upload_processor_spec.rb[1:1:4]" # L182rspec "./modules/vba_documents/spec/workers/upload_processor_spec.rb[1:1:25]" # L387rspec "./modules/vba_documents/spec/workers/upload_processor_spec.rb[1:1:12]" # L253rspec "./modules/vba_documents/spec/workers/upload_processor_spec.rb[1:1:2]" # L141rspec "./modules/vba_documents/spec/workers/upload_processor_spec.rb[1:1:10]" # L253rspec "./modules/vba_documents/spec/workers/upload_processor_spec.rb[1:1:36]" # L490rspec "./modules/vba_documents/spec/workers/upload_processor_spec.rb[1:1:18]" # L314rspec "./modules/vba_documents/spec/workers/upload_processor_spec.rb[1:1:15]" # L281rspec "./modules/vba_documents/spec/workers/upload_processor_spec.rb[1:1:22]" # L366rspec "./modules/vba_documents/spec/workers/upload_processor_spec.rb[1:1:43]" # L620rspec "./modules/vba_documents/spec/workers/upload_processor_spec.rb[1:1:3]" # L157rspec "./modules/vba_documents/spec/workers/upload_processor_spec.rb[1:1:40]" # L564rspec "./modules/vba_documents/spec/workers/upload_processor_spec.rb[1:1:38]" # L512rspec "./modules/vba_documents/spec/workers/upload_processor_spec.rb[1:1:32]" # L449rspec "./modules/vba_documents/spec/workers/upload_processor_spec.rb[1:1:19]" # L327rspec "./modules/vba_documents/spec/workers/upload_processor_spec.rb[1:1:20]" # L340rspec "./modules/vba_documents/spec/workers/upload_processor_spec.rb[1:1:42]" # L593rspec "./modules/vba_documents/spec/workers/upload_processor_spec.rb[1:1:7]" # L242rspec "./modules/vba_documents/spec/workers/upload_processor_spec.rb[1:1:29]" # L419rspec "./modules/vba_documents/spec/workers/upload_processor_spec.rb[1:1:27]" # L387rspec "./modules/vba_documents/spec/workers/upload_processor_spec.rb[1:1:31]" # L439rspec "./modules/vba_documents/spec/workers/upload_processor_spec.rb[1:1:16]" # L292rspec "./modules/vba_documents/spec/workers/upload_processor_spec.rb[1:1:41]" # L577rspec "./modules/vba_documents/spec/workers/upload_processor_spec.rb[1:1:9]" # L253rspec "./modules/vba_documents/spec/workers/upload_processor_spec.rb[1:1:24]" # L387rspec "./modules/vba_documents/spec/workers/upload_processor_spec.rb[1:1:5]" # L203rspec "./modules/vba_documents/spec/workers/upload_processor_spec.rb[1:1:11]" # L253rspec "./modules/vba_documents/spec/workers/upload_processor_spec.rb[1:1:23]" # L376rspec "./modules/vba_documents/spec/workers/upload_processor_spec.rb[1:1:21]" # L353rspec "./modules/vba_documents/spec/workers/upload_processor_spec.rb[1:1:35]" # L482rspec "./modules/vba_documents/spec/workers/upload_processor_spec.rb[1:1:33:1]" # L459rspec "./modules/vba_documents/spec/workers/upload_processor_spec.rb[1:1:39:2]" # L555rspec "./modules/vba_documents/spec/workers/upload_processor_spec.rb[1:1:39:1]" # L548rspec "./modules/vba_documents/spec/workers/upload_processor_spec.rb[1:1:34:1]" # L471rspec "./modules/vba_documents/spec/workers/upload_processor_spec.rb[1:1:28:2]" # L408rspec "./modules/vba_documents/spec/workers/upload_processor_spec.rb[1:1:28:1]" # L408rspec "./modules/vba_documents/spec/workers/upload_processor_spec.rb[1:1:45:1]" # L704rspec "./modules/vba_documents/spec/workers/upload_processor_spec.rb[1:1:45:4]" # L735rspec "./modules/vba_documents/spec/workers/upload_processor_spec.rb[1:1:45:2:1]" # L716rspec "./modules/vba_documents/spec/workers/upload_processor_spec.rb[1:1:45:3:1]" # L728rspec "./modules/vba_documents/spec/workers/upload_processor_spec.rb[1:1:1:1]" # L107rspec "./modules/vba_documents/spec/workers/upload_processor_spec.rb[1:1:44:2]" # L668rspec "./modules/vba_documents/spec/workers/upload_processor_spec.rb[1:1:44:1]" # L651rspec "./modules/vba_documents/spec/workers/upload_processor_spec.rb[1:1:44:3]" # L686rspec "./modules/vba_documents/spec/workers/upload_processor_spec.rb[1:1:37:2]" # L500rspec "./modules/vba_documents/spec/workers/upload_processor_spec.rb[1:1:37:1]" # L500rspec "./modules/vba_documents/spec/workers/upload_processor_spec.rb[1:1:6:1]" # L230rspec "./modules/vba_documents/spec/workers/upload_processor_spec.rb[1:1:6:2]" # L230rspec "./modules/vba_documents/spec/lib/upload_validator_spec.rb[1:1:1]" # L23rspec "./modules/vba_documents/spec/lib/upload_validator_spec.rb[1:1:3]" # L32rspec "./modules/vba_documents/spec/lib/upload_validator_spec.rb[1:1:2]" # L27rspec "./modules/claims_api/spec/workers/ews_updater_spec.rb[1:2:1]" # L43rspec "./modules/claims_api/spec/lib/claims_api/evidence_waiver_pdf_constructor/pdf_spec.rb[1:1:1]" # L24rspec "./modules/claims_api/spec/requests/v2/veterans/claims_request_spec.rb[1:1:1:7:1:1]" # L364rspec "./modules/claims_api/spec/lib/claims_api/local_bgs_spec.rb[1:1:2]" # L26rspec "./modules/claims_api/spec/models/veteran/service/user_spec.rb[1:1:3]" # L38rspec "./modules/claims_api/spec/models/veteran/service/user_spec.rb[1:1:2]" # L28rspec "./modules/claims_api/spec/models/veteran/service/user_spec.rb[1:1:4]" # L55rspec "./modules/claims_api/spec/models/veteran/service/user_spec.rb[1:1:1]" # L18rspec "./modules/facilities_api/spec/requests/facilities_api/apidoc_spec.rb[1:2:3:1]" # L65rspec "./modules/facilities_api/spec/requests/facilities_api/apidoc_spec.rb[1:2:4:1]" # L81rspec "./modules/vaos/spec/services/appointment_service_spec.rb[1:3:1:1]" # L121rspec "./modules/vaos/spec/services/middleware/vaos_logging_integration_spec.rb[1:1:3:2:1]" # L144rspec "./modules/vaos/spec/services/middleware/vaos_logging_integration_spec.rb[1:1:3:1:1]" # L98rspec "./modules/vaos/spec/services/middleware/vaos_logging_integration_spec.rb[1:1:2:1]" # L54rspec "./modules/vaos/spec/services/messages_service_spec.rb[1:1:2]" # L21rspec "./modules/health_quest/spec/request/patients_request_spec.rb[1:2:2:1]" # L85rspec "./modules/va_notify/spec/workers/email_job_spec.rb[1:1:1]" # L20rspec "./modules/va_notify/spec/workers/icn_job_spec.rb[1:1:1]" # L20rspec "./modules/veteran/spec/models/veteran/user_spec.rb[1:1:3]" # L29rspec "./modules/veteran/spec/models/veteran/user_spec.rb[1:1:1]" # L9rspec "./modules/veteran/spec/models/veteran/user_spec.rb[1:1:2]" # L19rspec "./modules/covid_vaccine/spec/jobs/covid_vaccine/registration_email_job_spec.rb[1:1:5]" # L59rspec "./modules/mobile/spec/workers/vet360_linking_spec.rb[1:2:1]" # L35rspec "./modules/covid_vaccine/spec/jobs/covid_vaccine/scheduled_batch_job_spec.rb[1:2:1:2:1]" # L60These specs are failing on the
ruby-3-0branch:rspec "./modules/appeals_api/spec/workers/pdf_submit_job_spec.rb[1:2:3]" # L115rspec "./modules/appeals_api/spec/workers/pdf_submit_job_spec.rb[1:2:1]" # L27rspec "./modules/covid_vaccine/spec/jobs/covid_vaccine/expanded_submission_state_job_spec.rb[1:2:2:1]" # L43rspec "./modules/covid_vaccine/spec/jobs/covid_vaccine/expanded_submission_state_job_spec.rb[1:2:1:1]" # L26rspec "./modules/vaos/spec/services/middleware/vaos_logging_spec.rb[1:2:2]" # L90rspec "./modules/vaos/spec/services/middleware/vaos_logging_spec.rb[1:2:3]" # L100rspec "./modules/vaos/spec/services/middleware/vaos_logging_spec.rb[1:2:1]" # L80rspec "./modules/vaos/spec/services/middleware/vaos_logging_spec.rb[1:1:2]" # L49rspec "./modules/vaos/spec/services/middleware/vaos_logging_spec.rb[1:1:1]" # L36rspec "./modules/vaos/spec/services/middleware/vaos_logging_spec.rb[1:1:3]" # L62rspec "./modules/check_in/spec/request/v2/pre_check_ins_request_spec.rb[1:2:3:1]" # L311rspec "./modules/check_in/spec/request/v2/pre_check_ins_request_spec.rb[1:2:1:1]" # L220rspec "./modules/check_in/spec/request/v2/pre_check_ins_request_spec.rb[1:2:2:1]" # L268rspec "./modules/check_in/spec/request/v2/pre_check_ins_request_spec.rb[1:1:2:1]" # L177The text was updated successfully, but these errors were encountered: