Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ruby 3 Upgrade: Fix failing tests in modules/check_in/spec/request/v2/sessions_request_spec.rb #12074

Merged

Conversation

holdenhinkle
Copy link
Contributor

@holdenhinkle holdenhinkle commented Mar 13, 2023

Referencing ticket department-of-veterans-affairs/va.gov-team#54796

Fix the following tests:

 rspec "./modules/check_in/spec/request/v2/sessions_request_spec.rb[1:2:2:1]" # L248
 rspec "./modules/check_in/spec/request/v2/sessions_request_spec.rb[1:2:3:1]" # L278
 rspec "./modules/check_in/spec/request/v2/sessions_request_spec.rb[1:2:4:1:1:2]" # L336
 rspec "./modules/check_in/spec/request/v2/sessions_request_spec.rb[1:2:4:1:1:1]" # L327
 rspec "./modules/check_in/spec/request/v2/sessions_request_spec.rb[1:2:4:1:2:3]" # L387
 rspec "./modules/check_in/spec/request/v2/sessions_request_spec.rb[1:2:4:1:2:2]" # L374
 rspec "./modules/check_in/spec/request/v2/sessions_request_spec.rb[1:2:4:1:2:1]" # L361
 rspec "./modules/check_in/spec/request/v2/sessions_request_spec.rb[1:2:1:1]" # L227
 rspec "./modules/check_in/spec/request/v2/sessions_request_spec.rb[1:2:5:2:1]" # L434
 rspec "./modules/check_in/spec/request/v2/sessions_request_spec.rb[1:2:5:3:1]" # L450
 rspec "./modules/check_in/spec/request/v2/sessions_request_spec.rb[1:2:5:1:1]" # L418
 rspec "./modules/check_in/spec/request/v2/sessions_request_spec.rb[1:1:3:1]" # L84

Ruby 2.7 deprecated automatic casting of a hash passed as the last argument of a method to keyword arguments. You must now use actual keyword arguments (foo(bar: 'baz') instead of foo({bar: 'baz'})) or cast the hash to keyword args using the double splat (foo(**{bar: 'baz'})).

@holdenhinkle holdenhinkle requested review from a team as code owners March 13, 2023 16:08
@ericboehs ericboehs merged commit e6b9ede into master Mar 13, 2023
@ericboehs ericboehs deleted the hh-ruby-3-upgrade-fix-check_in-sessions_request_specs branch March 13, 2023 16:13
@holdenhinkle holdenhinkle changed the title Ruby 3 Upgrade: Fix failing modules/check_in/spec/request/v2/sessions_request_spec.rb Ruby 3 Upgrade: Fix failing tests in modules/check_in/spec/request/v2/sessions_request_spec.rb Mar 13, 2023
CBonade pushed a commit that referenced this pull request Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants