Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ruby 3 KwArgs: Fix Vaos Logging Spec #12032

Merged
merged 0 commits into from
Mar 9, 2023
Merged

Conversation

ericboehs
Copy link
Contributor

@ericboehs ericboehs commented Mar 9, 2023

Ruby 2.7 deprecated automatic casting of a hash passed as the last argument of a method to keyword arguments. You must now use actual keyword arguments (foo(bar: 'baz') instead of foo({bar: 'baz'})) or cast the hash to keyword args using the double splat (foo(**{bar: 'baz'})).

In preparation for upgrading to Ruby 3.0, we're implementing the new syntax for Vaos Logging spec.

Fixes tests:

rspec "./modules/vaos/spec/services/middleware/vaos_logging_spec.rb[1:2:3]" # L100
rspec "./modules/vaos/spec/services/middleware/vaos_logging_spec.rb[1:2:1]" # L80
rspec "./modules/vaos/spec/services/middleware/vaos_logging_spec.rb[1:2:2]" # L90
rspec "./modules/vaos/spec/services/middleware/vaos_logging_spec.rb[1:1:3]" # L62
rspec "./modules/vaos/spec/services/middleware/vaos_logging_spec.rb[1:1:1]" # L36

Pulled from: department-of-veterans-affairs/va.gov-team#54796

@ericboehs ericboehs requested review from a team as code owners March 9, 2023 02:28
@github-actions github-actions bot added the VAOS Va Online Scheduling Contract label Mar 9, 2023
@va-vfs-bot va-vfs-bot temporarily deployed to eb-r3k-vaos-logging-spec/main/main March 9, 2023 02:29 Inactive
@ericboehs ericboehs enabled auto-merge (squash) March 9, 2023 02:29
@va-vfs-bot va-vfs-bot temporarily deployed to eb-r3k-vaos-logging-spec/main/main March 9, 2023 02:42 Inactive
LindseySaari
LindseySaari previously approved these changes Mar 9, 2023
holdenhinkle
holdenhinkle previously approved these changes Mar 9, 2023
@ericboehs ericboehs merged commit 1363f4c into master Mar 9, 2023
@ericboehs ericboehs deleted the eb-r3k-vaos-logging-spec branch March 9, 2023 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
VAOS Va Online Scheduling Contract
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants