Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ruby 3 Upgrade: Fix tests in modules/check_in/spec/request/v0/travel_claims_request_spec.rb #12084

Merged
merged 0 commits into from
Mar 14, 2023

Conversation

holdenhinkle
Copy link
Contributor

Referencing ticket department-of-veterans-affairs/va.gov-team#54796

Fix the following tests:

 rspec "./modules/check_in/spec/request/v0/travel_claims_request_spec.rb[1:1:3:1:1]" # L86
 rspec "./modules/check_in/spec/request/v0/travel_claims_request_spec.rb[1:1:3:4:1]" # L158
 rspec "./modules/check_in/spec/request/v0/travel_claims_request_spec.rb[1:1:3:6:1]" # L206
 rspec "./modules/check_in/spec/request/v0/travel_claims_request_spec.rb[1:1:3:5:1]" # L182
 rspec "./modules/check_in/spec/request/v0/travel_claims_request_spec.rb[1:1:3:2:1]" # L110
 rspec "./modules/check_in/spec/request/v0/travel_claims_request_spec.rb[1:1:3:3:1]" # L134

Ruby 2.7 deprecated automatic casting of a hash passed as the last argument of a method to keyword arguments. You must now use actual keyword arguments (foo(bar: 'baz') instead of foo({bar: 'baz'})) or cast the hash to keyword args using the double splat (foo(**{bar: 'baz'})).

@ericboehs ericboehs merged commit 02c6601 into master Mar 14, 2023
@ericboehs ericboehs deleted the hh-ruby-3-upgrade-fix-travel_claims_request_specs branch March 14, 2023 00:42
CBonade pushed a commit that referenced this pull request Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants