Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task update native doc #12297

Merged
merged 0 commits into from
Apr 14, 2023
Merged

Task update native doc #12297

merged 0 commits into from
Apr 14, 2023

Conversation

lukey-luke
Copy link
Contributor

Note: Delete the description statements, complete each step. None are optional, but can be justified as to why they cannot be completed as written. Provide known gaps to testing that may raise the risk of merging to production.

Summary

  • Adds notes on installing and running redis for local OSX setup

Related issue(s)

  • Difficulty getting the repo running.

Testing done

  • n/a, I followed these commands to get vets-api running

Screenshots

Note: Optional

What areas of the site does it impact?

(Describe what parts of the site are impacted andifcode touched other areas)

  • n/a

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

Requested Feedback

n/a, feedback given in #vfs-platform-support slack channel

@lukey-luke lukey-luke merged commit 411bb76 into master Apr 14, 2023
@lukey-luke lukey-luke deleted the task-update-native-doc branch April 14, 2023 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants