add redis to OSX getting started native doc #11969
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
va-vfs-bot
temporarily deployed
to
task-update-getting-started/main/main
* Increase delay between 686c and 674 form submissions Long ago, in #7811, a two-minute delay was set between BGS::SubmitForm686cJob and BGS::SubmitForm674Job, in an attempt to avoid a race condition that produced null dependency claims. The race condition is still occuring, so as a short-term fix, this PR increases the delay to five minutes. Here's some more detail on that issue, and the short-term fix implemented here: - When a vet submits their form on VA.gov, we sometimes enqueue a job to submit a 686c form to BGS and another job to submit a 674 form to BGS. - Both of these jobs, among other things, first fetch an `incremental` from BGS via a `findBenefitClaimTypeIncrement` endpoint, and then submit this `incremental` along with the vet's form data to BGS via a `insertBenefitClaim` endpoint. The `incremental` is akin to an incrementing ID or serial number. It starts at "130" for each veteran, and every time a veteran makes a successful request to the `insertBenefitClaim` endpoint, the `increment` increases by 1. So the next time a veteran consumes the `findBenefitClaimTypeIncrement` endpoint, they will get an `incremental` of "131." - BGS requires every veterans' requests to the `insertBenefitClaim` endpoint to have a unique `incremental`. In other words, a veteran cannot make two requests to `insertBenefitClaim` with the same `incremental`. If they do, a null dependency claim is generated and a "Duplicate Benefit Claims found on the Corporate Database" error is thrown. This is why VA.gov's 686c and 674 submission jobs are both written to fetch the next `incremental` from the `findBenefitClaimTypeIncrement` before consuming the `insertBenefitClaim` endpoint. - But here's what VA.gov gets wrong: sometimes we run the 674 job before the 686c submission is complete. Meaning, we ask for 674's `incremental` before it has been updated by 686c's submission request. Consequently, both submission requests use the same `incremental`, and the latter request fails, thereby producing a null claim. - In #7811, previous devs tried to avoid this issue by scheduling the 674 job to run two minutes after enqueueing the 686c job. But, given the large volume of null dependency claims we have been seeing, two minutes is not enough. - A short term fix for this issue is to increase that two minute delay to a five minute delay. That's what I've done here. This should dramatically reduce the number of null dependency claims, but there will still be a remote possibility that null claims will be created. - A better, long-term fix will be to re-write the code to force the two jobs to run consecutively. I recommend doing that some time in the near future.
* Bump rubocop-rails from 2.17.4 to 2.18.0 Bumps [rubocop-rails](https://github.com/rubocop/rubocop-rails) from 2.17.4 to 2.18.0. - [Release notes](https://github.com/rubocop/rubocop-rails/releases) - [Changelog](https://github.com/rubocop/rubocop-rails/blob/master/CHANGELOG.md) - [Commits](rubocop/rubocop-rails@v2.17.4...v2.18.0) --- updated-dependencies: - dependency-name: rubocop-rails dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Use exclude instead of inverting include * Use instead of inverting * Use instead of inverting . * Use instead of inverting * Use instead of inverting . --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Ryan Johnson <ryan.johnson@oddball.io>
…V0 routing rspecs (#12007) * removed vaos v0 limits controller limit serializer and routing rspecs
* return from prefill_compensation_type if disability rating is nil * lint
* mock_authorization authorize route setup * moves mocked_authentication to module * spec update * spec updates * spec updates * mocked auth service work * rubocop path fix * syntax fix * removes unneeded instance variable usage
* initial removal * restores terms & conditions * remove mhv_account from terms_and_conditions_acceptance & swagger * spec fix * removes mhv account from redis & mhv_account_ineligible * removes account_statistics_job_spec
* 53958 CHIP initiate_check_in service method * Empty line commit to initiate test workflow --------- Co-authored-by: kanchanasuriya <ksuriyamoorthy@kindsys.us>
* Add direct deposit service and specs * Remove PUT specs to keep PR under 500 lines. * Add comp and pen controller and specs * Add controller tests and refactor code * Remove unused methods from control_information class * Update account_type validation logic to match on uppercase values * Update payment_information mapping functionality * Fix linting issue * Condense multiple lighthouse policies into a single policy * Fix authorized services spec
* 4842: remove unused maintenance window
* Replace FastJsonapi with JSONAPI * Fix up ClaimOverviewSerializer
Ruby 2.7 deprecated automatic casting of a hash passed as the last argument of a method to keyword arguments. You must now use actual keyword arguments (`foo(bar: 'baz')` instead of `foo({bar: 'baz'})`) or cast the hash to keyword args using the double splat (`foo(**{bar: 'baz'})`).
In preparation for upgrading to Ruby 3.0, we're implementing the new syntax for `V2::PreCheckInsController` spec.
Bumps [sidekiq-scheduler](https://github.com/moove-it/sidekiq-scheduler) from 5.0.1 to 5.0.2. - [Release notes](https://github.com/moove-it/sidekiq-scheduler/releases) - [Changelog](https://github.com/sidekiq-scheduler/sidekiq-scheduler/blob/master/CHANGELOG.md) - [Commits](sidekiq-scheduler/sidekiq-scheduler@v5.0.1...v5.0.2) --- updated-dependencies: - dependency-name: sidekiq-scheduler dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [puma](https://github.com/puma/puma) from 6.1.0 to 6.1.1. - [Release notes](https://github.com/puma/puma/releases) - [Changelog](https://github.com/puma/puma/blob/master/History.md) - [Commits](puma/puma@v6.1.0...v6.1.1) --- updated-dependencies: - dependency-name: puma dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
va-vfs-bot
temporarily deployed
to
task-update-getting-started/main/main
* API-24392: Add feature flag monitoring job for VBADocuments * API-24392: Simplify since only DefaultNotification exists for now * API-24392: Rename to
- Removes former user no longer on the project. Co-authored-by: Daniel Sasser <daniel.sasser@agile6.com>
* Upgrade to Ruby 3.1 * Fix boot error See https://stackoverflow.com/questions/71191685/visit-psych-nodes-alias-unknown-alias-default-psychbadalias * RuboCop: Auto correct Style/HashSyntax Also corrects other Offenses which came up when correcting for HashSyntax: - Style/IfUnlessModifier - Layout/FirstArgumentIndentation - Layout/FirstHashElementIndentation * RuboCop: Auto correct Naming/BlockForwarding * RuboCop: Auto correct Style/ArrayIntersect * Spec Fix: Mobile Claims and Appeals request spec
Updates flipper access for Adrian Rollett. (Newly an OCTO engineer)
…o task-update-getting-started
va-vsp-bot
requested a deployment
to
master/main/task-update-getting-started
|
closing in favor of #12297 Too many changes in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: Delete the description statements, complete each step. None are optional, but can be justified as to why they cannot be completed as written. Provide known gaps to testing that may raise the risk of merging to production.
Summary
Related issue(s)
Testing done
Screenshots
Note: Optional
What areas of the site does it impact?
(Describe what parts of the site are impacted andifcode touched other areas)
Acceptance criteria
Requested Feedback
n/a, feedback given in #vfs-platform-support slack channel