migration to convert zipcode data type to string

[jtmst]

Note: Delete the description statements, complete each step. None are optional, but can be justified as to why they cannot be completed as written. Provide known gaps to testing that may raise the risk of merging to production.

Summary

• Updates the zip code data type in std_zipcodes to be a string
• zipcodes originally stored as ints result in leading 0's being removed and zipcodes being stored inaccurately.
• per feedback given on this pr 13558 income limits logic #12877

NOTE

• temporarily disables two tests for the purposes of running the migration, tests to be reenabled in follow up PR here: modify sidekiq job and tests for string zip codes #12979

Related issue(s)

• I.L. BE: Alter CSV import pipeline and vets-api tables to preserve leading zeroes on zip codes va.gov-cms#14059

Testing done

• ran migration locally and verified correct change in schema

Screenshots

Note: Optional

What areas of the site does it impact?

(Describe what parts of the site are impacted andifcode touched other areas)

Acceptance criteria

• I fixed|updated|added unit tests and integration tests for each feature (if applicable).
• No error nor warning in the console.
• Events are being sent to the appropriate logging solution
• Documentation has been updated (link to documentation)
• No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
• Feature/bug has a monitor built into Datadog or Grafana (if applicable)
• If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
• I added a screenshot of the developed feature

Requested Feedback

(OPTIONAL)What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?

[github-actions]

1 Error

🚫

Modified files in db/ should be the only files checked into this PR. File Summary DB File(s) db/migrate/20230613132004_zipcode_data_type_to_string.rb db/schema.rb App File(s) spec/jobs/income_limits/std_zipcode_import_spec.rb Database migrations do not run automatically with vets-api deployments. Application code must always be backwards compatible with the DB, both before and after migrations have been run. For more info: vets-api Database Migrations vets-api Deployment Process

Generated by 🚫 Danger

[jeremy6d]

Bypassed the prohibition on migration PRs not having changes in other sectors of the codebase to prevent Josh from having to submit 3 PRs for a simple change