-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
modify sidekiq job and tests for string zip codes #12979
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
va-vfs-bot
temporarily deployed
to
14059-update-sidekiq-jobs-for-zipcode-data/main/main
June 13, 2023 14:19
Inactive
va-vsp-bot
requested a deployment
to
14059-update-sidekiq-jobs-for-zipcode-data/main/main
June 13, 2023 14:19
In progress
va-vfs-bot
temporarily deployed
to
14059-update-sidekiq-jobs-for-zipcode-data/main/main
June 13, 2023 14:32
Inactive
8 tasks
va-vsp-bot
requested a deployment
to
14059-update-sidekiq-jobs-for-zipcode-data/main/main
June 14, 2023 19:01
In progress
jtmst
force-pushed
the
14059-update-sidekiq-jobs-for-zipcode-data
branch
from
June 14, 2023 19:04
3d1ef0c
to
f79b9b5
Compare
va-vsp-bot
requested a deployment
to
14059-update-sidekiq-jobs-for-zipcode-data/main/main
June 14, 2023 19:05
In progress
va-vfs-bot
temporarily deployed
to
14059-update-sidekiq-jobs-for-zipcode-data/main/main
June 14, 2023 19:07
Inactive
va-vsp-bot
requested a deployment
to
14059-update-sidekiq-jobs-for-zipcode-data/main/main
June 15, 2023 13:31
In progress
va-vsp-bot
requested a deployment
to
14059-update-sidekiq-jobs-for-zipcode-data/main/main
June 15, 2023 14:41
In progress
va-vfs-bot
temporarily deployed
to
14059-update-sidekiq-jobs-for-zipcode-data/main/main
June 15, 2023 14:42
Inactive
dsasser
previously approved these changes
Jun 15, 2023
ryan-mcneil
previously approved these changes
Jun 15, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👌
va-vsp-bot
requested a deployment
to
14059-update-sidekiq-jobs-for-zipcode-data/main/main
June 15, 2023 18:29
In progress
ryan-mcneil
approved these changes
Jun 15, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👌
ryan-mcneil
pushed a commit
that referenced
this pull request
Dec 11, 2023
* modify sidekiq job and tests for string zip codes * lint * remove test skips * test update * update zip job
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: Delete the description statements, complete each step. None are optional, but can be justified as to why they cannot be completed as written. Provide known gaps to testing that may raise the risk of merging to production.
Summary
Related issue(s)
Testing done
Screenshots
Note: Optional
What areas of the site does it impact?
(Describe what parts of the site are impacted andifcode touched other areas)
Acceptance criteria
Requested Feedback
(OPTIONAL)What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?