Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modify sidekiq job and tests for string zip codes #12979

Merged
merged 0 commits into from
Jun 15, 2023

Conversation

jtmst
Copy link
Contributor

@jtmst jtmst commented Jun 13, 2023

Note: Delete the description statements, complete each step. None are optional, but can be justified as to why they cannot be completed as written. Provide known gaps to testing that may raise the risk of merging to production.

Summary

Related issue(s)

  • department-of-veterans-affairs/va.gov-team#0000
  • Link to ticket created in va.gov-team repo
  • Link to previous change of the code/bug (if applicable)
  • Link to epic if not included in ticket

Testing done

Screenshots

Note: Optional

What areas of the site does it impact?

(Describe what parts of the site are impacted andifcode touched other areas)

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

Requested Feedback

(OPTIONAL)What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?

@jtmst jtmst requested review from a team as code owners June 13, 2023 14:14
@va-vfs-bot va-vfs-bot temporarily deployed to 14059-update-sidekiq-jobs-for-zipcode-data/main/main June 13, 2023 14:19 Inactive
@va-vsp-bot va-vsp-bot requested a deployment to 14059-update-sidekiq-jobs-for-zipcode-data/main/main June 13, 2023 14:19 In progress
@va-vfs-bot va-vfs-bot temporarily deployed to 14059-update-sidekiq-jobs-for-zipcode-data/main/main June 13, 2023 14:32 Inactive
@va-vsp-bot va-vsp-bot requested a deployment to 14059-update-sidekiq-jobs-for-zipcode-data/main/main June 14, 2023 19:01 In progress
@jtmst jtmst force-pushed the 14059-update-sidekiq-jobs-for-zipcode-data branch from 3d1ef0c to f79b9b5 Compare June 14, 2023 19:04
@va-vsp-bot va-vsp-bot requested a deployment to 14059-update-sidekiq-jobs-for-zipcode-data/main/main June 14, 2023 19:05 In progress
@va-vfs-bot va-vfs-bot temporarily deployed to 14059-update-sidekiq-jobs-for-zipcode-data/main/main June 14, 2023 19:07 Inactive
@va-vsp-bot va-vsp-bot requested a deployment to 14059-update-sidekiq-jobs-for-zipcode-data/main/main June 15, 2023 13:31 In progress
@va-vsp-bot va-vsp-bot requested a deployment to 14059-update-sidekiq-jobs-for-zipcode-data/main/main June 15, 2023 14:41 In progress
@va-vfs-bot va-vfs-bot temporarily deployed to 14059-update-sidekiq-jobs-for-zipcode-data/main/main June 15, 2023 14:42 Inactive
@jtmst jtmst requested review from maxx1128 and dsasser June 15, 2023 14:58
dsasser
dsasser previously approved these changes Jun 15, 2023
ryan-mcneil
ryan-mcneil previously approved these changes Jun 15, 2023
Copy link
Contributor

@ryan-mcneil ryan-mcneil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

Copy link
Contributor

@ryan-mcneil ryan-mcneil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@jtmst jtmst merged commit 5cb9a05 into master Jun 15, 2023
@jtmst jtmst deleted the 14059-update-sidekiq-jobs-for-zipcode-data branch June 15, 2023 18:46
ryan-mcneil pushed a commit that referenced this pull request Dec 11, 2023
* modify sidekiq job and tests for string zip codes

* lint

* remove test skips

* test update

* update zip job
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants