Remove willRefinance parameter from payload to LGY.

LGY's API docs indicate that they don't accept this parameter, we never sent the parameter to begin with, and although we used to collect it on the front end (i.e. "Do you want to refinance this loan?"), now that we are sending a loan intent for each loan (See department-of-veterans-affairs/vets-api#11666 and #23249), this question is unnecessary because the loan intent answers the question.
department-of-veterans-affairs · Jan 30, 2023 · e1cb687 · e1cb687
1 parent 14dfbd3
commit e1cb687
Show file tree

Hide file tree

Showing 6 changed files with 6 additions and 26 deletions.
diff --git a/src/applications/lgy/coe/form/config/chapters/loans/loanHistory.js b/src/applications/lgy/coe/form/config/chapters/loans/loanHistory.js
@@ -88,9 +88,6 @@ export const schema = {
             type: 'boolean',
           },
           intent: LOAN_INTENT_SCHEMA,
-          willRefinance: {
-            type: 'boolean',
-          },
         },
       },
     },
@@ -188,13 +185,6 @@ export const uiSchema = {
           expandUnder: 'propertyOwned',
         },
       },
-      willRefinance: {
-        'ui:title': text.refinance.title,
-        'ui:widget': 'yesNo',
-        'ui:options': {
-          hideEmptyValueInReview: true,
-        },
-      },
     },
   },
 };
diff --git a/src/applications/lgy/coe/form/content/loanHistory.js b/src/applications/lgy/coe/form/content/loanHistory.js
@@ -49,8 +49,4 @@ export default {
     title: 'Do you still own this property?',
     value: data => (get('propertyOwned', data, '') ? 'Yes' : 'No'),
   },
-  refinance: {
-    title: 'Do you want to refinance this loan?',
-    value: data => (get('willRefinance', data, '') ? 'Yes' : 'No'),
-  },
 };
diff --git a/src/applications/lgy/coe/form/tests/coe-keyboard-only.cypress.spec.js b/src/applications/lgy/coe/form/tests/coe-keyboard-only.cypress.spec.js
@@ -173,8 +173,6 @@ describe('Certificate of Eligibility keyboard only navigation', () => {
         cy.tabToElement(`[name="${root}intent"]`);
         cy.chooseRadio(firstLoan.intent);
       }
-      cy.tabToElement(`[name="${root}willRefinance"]`);
-      cy.chooseRadio(firstLoan.willRefinance ? 'Y' : 'N');
     }
 
     cy.tabToContinueForm();

diff --git a/src/applications/lgy/coe/form/tests/config/loans/loanHistory.unit.spec.jsx b/src/applications/lgy/coe/form/tests/config/loans/loanHistory.unit.spec.jsx
@@ -33,7 +33,7 @@ describe('COE applicant loan history', () => {
       </Provider>,
     );
 
-    expect($$('input', container).length).to.equal(11);
+    expect($$('input', container).length).to.equal(9);
     expect($$('select', container).length).to.equal(3);
   });
 
@@ -49,7 +49,7 @@ describe('COE applicant loan history', () => {
       </Provider>,
     );
 
-    expect($$('input', container).length).to.equal(16);
+    expect($$('input', container).length).to.equal(14);
     expect($$('select', container).length).to.equal(3);
   });
 

diff --git a/src/applications/lgy/coe/form/tests/fixtures/data/maximal-test.json b/src/applications/lgy/coe/form/tests/fixtures/data/maximal-test.json
@@ -47,8 +47,7 @@
         "propertyZip": "85274"
       },
       "vaLoanNumber": "12-34-5-6789012",
-      "propertyOwned": true,
-      "willRefinance": false
+      "propertyOwned": true
     },
     {
       "intent": "REFI",
@@ -63,8 +62,7 @@
         "propertyZip": "85274"
       },
       "vaLoanNumber": "21 09 8 7654321",
-      "propertyOwned": true,
-      "willRefinance": false
+      "propertyOwned": true
     }
   ],
   "files": [

diff --git a/src/applications/lgy/coe/form/tests/fixtures/data/transformed-maximal-test.json b/src/applications/lgy/coe/form/tests/fixtures/data/transformed-maximal-test.json
@@ -49,8 +49,7 @@
             "propertyZip": "85274"
           },
           "vaLoanNumber": "123456789012",
-          "propertyOwned": true,
-          "willRefinance": false
+          "propertyOwned": true
         },
         {
           "intent": "REFI",
@@ -66,8 +65,7 @@
             "propertyZip": "85274"
           },
           "vaLoanNumber": "210987654321",
-          "propertyOwned": true,
-          "willRefinance": false
+          "propertyOwned": true
         }
       ],
       "files": [