Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[52510] Specify intent for every loan in COE form. #11666

Merged
merged 0 commits into from
Jan 30, 2023

Conversation

data-doge
Copy link
Contributor

@data-doge data-doge commented Jan 27, 2023

Summary

The COE form was originally designed to accept a singular loan intent, regardless of how many other prior loans a vet specified in the form. We have since learned that each loan should have its own intent. This PR accompanies department-of-veterans-affairs/vets-website#23249, and sends a separate intent for each loan, to LGY.

I am on the benefit decision reviews team (fka benefits team 1), who is currently responsible for the COE form.

This work is behind a feature toggle, and exposed only to a limited number of users taking part in our pilot test sessions.

Related issue(s)

Testing done

  • Describe what the old behavior was prior to the change
  • Describe the steps required to verify your changes are working as expected
  • Describe the tests completed and the results

Screenshots

Note: Optional

What areas of the site does it impact?

COE form

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

Requested Feedback

(OPTIONAL)What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?

@data-doge data-doge merged commit cb6c258 into master Jan 30, 2023
@data-doge data-doge deleted the 52510-allow-multiple-loan-intent-submission branch January 30, 2023 16:41
data-doge added a commit to department-of-veterans-affairs/vets-website that referenced this pull request Jan 30, 2023
LGY's API docs indicate that they don't accept this parameter, we never sent the parameter to begin with, and although we used to collect it on the front end (i.e. "Do you want to refinance this loan?"), now that we are sending a loan intent for each loan (See department-of-veterans-affairs/vets-api#11666 and #23249), this question is unnecessary because the loan intent answers the question.
data-doge added a commit to department-of-veterans-affairs/vets-website that referenced this pull request Jan 30, 2023
LGY's API docs indicate that they don't accept this parameter, we never sent the parameter to begin with, and although we used to collect it on the front end (i.e. "Do you want to refinance this loan?"), now that we are sending a loan intent for each loan (See department-of-veterans-affairs/vets-api#11666 and #23249), this question is unnecessary because the loan intent answers the question.
data-doge added a commit that referenced this pull request Jan 31, 2023
LGY's API docs indicate that they don't accept this parameter, we never sent the parameter to begin with, and although we used to collect it on the front end (i.e. "Do you want to refinance this loan?"), now that we are sending a loan intent for each loan (See #11666 and department-of-veterans-affairs/vets-website#23249), this question is unnecessary because the loan intent answers the question.
data-doge added a commit to department-of-veterans-affairs/vets-website that referenced this pull request Jan 31, 2023
LGY's API docs indicate that they don't accept this parameter, we never sent the parameter to begin with, and although we used to collect it on the front end (i.e. "Do you want to refinance this loan?"), now that we are sending a loan intent for each loan (See department-of-veterans-affairs/vets-api#11666 and #23249), this question is unnecessary because the loan intent answers the question.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants