Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove willRefinance parameter from payload to LGY. #23254

Merged
merged 1 commit into from
Jan 31, 2023

Conversation

data-doge
Copy link
Contributor

@data-doge data-doge commented Jan 30, 2023

Summary

Remove willRefinance parameter from payload to LGY.

LGY's API docs indicate that they don't accept this parameter, we never sent the parameter to begin with, and although we used to collect it on the front end (i.e. "Do you want to refinance this loan?"), now that we are sending a loan intent for each loan (See department-of-veterans-affairs/vets-api#11666 and #23249), this question is unnecessary because the loan intent answers the question.

I'm on the benefits decision reviews team (fka benefits team 1), which is currently responsible for the COE form.

This work is behind a feature toggle that is only switched on for a limited number of vets participating in our pilot launch.

Related issue(s)

Testing done

  • Updated specs

Screenshots

Note: This field is mandatory for component work and UI changes (non-component work should NOT have screenshots).

Before After
Mobile
Desktop

What areas of the site does it impact?

COE form

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

Requested Feedback

(OPTIONAL)What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?

LGY's API docs indicate that they don't accept this parameter, we never sent the parameter to begin with, and although we used to collect it on the front end (i.e. "Do you want to refinance this loan?"), now that we are sending a loan intent for each loan (See department-of-veterans-affairs/vets-api#11666 and #23249), this question is unnecessary because the loan intent answers the question.
@data-doge data-doge self-assigned this Jan 31, 2023
@data-doge data-doge merged commit 9720686 into main Jan 31, 2023
@data-doge data-doge deleted the 52510-remove-will-refinance-question branch January 31, 2023 18:43
data-doge added a commit to department-of-veterans-affairs/vets-json-schema that referenced this pull request Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants