Remove willRefinance
parameter from payload to LGY.
#23254
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Remove
willRefinance
parameter from payload to LGY.LGY's API docs indicate that they don't accept this parameter, we never sent the parameter to begin with, and although we used to collect it on the front end (i.e. "Do you want to refinance this loan?"), now that we are sending a loan intent for each loan (See department-of-veterans-affairs/vets-api#11666 and #23249), this question is unnecessary because the loan intent answers the question.
I'm on the benefits decision reviews team (fka benefits team 1), which is currently responsible for the COE form.
This work is behind a feature toggle that is only switched on for a limited number of vets participating in our pilot launch.
Related issue(s)
Testing done
Screenshots
Note: This field is mandatory for component work and UI changes (non-component work should NOT have screenshots).
What areas of the site does it impact?
COE form
Acceptance criteria
Requested Feedback
(OPTIONAL)What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?