Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove willRefinance parameter from payload to LGY. #23254

Merged
merged 1 commit into from
Jan 31, 2023
Merged

Remove willRefinance parameter from payload to LGY. #23254

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions src/applications/lgy/coe/form/config/chapters/loans/loanHistory.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,9 +88,6 @@ export const schema = {
type: 'boolean',
},
intent: LOAN_INTENT_SCHEMA,
willRefinance: {
type: 'boolean',
},
},
},
},
Expand Down Expand Up @@ -188,13 +185,6 @@ export const uiSchema = {
expandUnder: 'propertyOwned',
},
},
willRefinance: {
'ui:title': text.refinance.title,
'ui:widget': 'yesNo',
'ui:options': {
hideEmptyValueInReview: true,
},
},
},
},
};
4 changes: 0 additions & 4 deletions src/applications/lgy/coe/form/content/loanHistory.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,8 +49,4 @@ export default {
title: 'Do you still own this property?',
value: data => (get('propertyOwned', data, '') ? 'Yes' : 'No'),
},
refinance: {
title: 'Do you want to refinance this loan?',
value: data => (get('willRefinance', data, '') ? 'Yes' : 'No'),
},
};
2 changes: 0 additions & 2 deletions src/applications/lgy/coe/form/tests/coe-keyboard-only.cypress.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,8 +173,6 @@ describe('Certificate of Eligibility keyboard only navigation', () => {
cy.tabToElement(`[name="${root}intent"]`);
cy.chooseRadio(firstLoan.intent);
}
cy.tabToElement(`[name="${root}willRefinance"]`);
cy.chooseRadio(firstLoan.willRefinance ? 'Y' : 'N');
}

cy.tabToContinueForm();
Expand Down
4 changes: 2 additions & 2 deletions src/applications/lgy/coe/form/tests/config/loans/loanHistory.unit.spec.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ describe('COE applicant loan history', () => {
</Provider>,
);

expect($$('input', container).length).to.equal(11);
expect($$('input', container).length).to.equal(9);
expect($$('select', container).length).to.equal(3);
});

Expand All @@ -49,7 +49,7 @@ describe('COE applicant loan history', () => {
</Provider>,
);

expect($$('input', container).length).to.equal(16);
expect($$('input', container).length).to.equal(14);
expect($$('select', container).length).to.equal(3);
});

Expand Down
6 changes: 2 additions & 4 deletions src/applications/lgy/coe/form/tests/fixtures/data/maximal-test.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,8 +47,7 @@
"propertyZip": "85274"
},
"vaLoanNumber": "12-34-5-6789012",
"propertyOwned": true,
"willRefinance": false
"propertyOwned": true
},
{
"intent": "REFI",
Expand All @@ -63,8 +62,7 @@
"propertyZip": "85274"
},
"vaLoanNumber": "21 09 8 7654321",
"propertyOwned": true,
"willRefinance": false
"propertyOwned": true
}
],
"files": [
Expand Down
6 changes: 2 additions & 4 deletions src/applications/lgy/coe/form/tests/fixtures/data/transformed-maximal-test.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,8 +49,7 @@
"propertyZip": "85274"
},
"vaLoanNumber": "123456789012",
"propertyOwned": true,
"willRefinance": false
"propertyOwned": true
},
{
"intent": "REFI",
Expand All @@ -66,8 +65,7 @@
"propertyZip": "85274"
},
"vaLoanNumber": "210987654321",
"propertyOwned": true,
"willRefinance": false
"propertyOwned": true
}
],
"files": [
Expand Down