Upgrade eslint-config-airbnb #12760
Merged
Upgrade eslint-config-airbnb #12760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
17 tasks
bkjohnson
reviewed
May 21, 2020
Comment on lines
+32
to
+35
| // "no-unused-vars": [ | ||
| // 2, | ||
| // { "args": "after-used", "argsIgnorePattern": "^_", "vars": "local" } | ||
| // ], |
There was a problem hiding this comment.
What are the errors that are preventing this rule from staying on?
There was a problem hiding this comment.
This rule was commented out here because it was added to the audit on line 122. We will activate it once all errors are fixed.
| @@ -27,12 +27,12 @@ | |||
| "rules": { | |||
| /* || Eslint main rules || */ | |||
| "camelcase": [2, { "properties": "always" }], // Override airbnb style. | |||
| "func-names": 2, | |||
| // "func-names": 2, | |||
There was a problem hiding this comment.
This rule as well. Why are we changing it?
There was a problem hiding this comment.
This rule was commented out here because it was added to the audit on line 119. We will activate it once all errors are fixed.
|
I added the current errors to each rule as a comment. |
1Copenut
approved these changes
May 27, 2020
|
I'll be working on turning some of these on soon. I noticed there are some |
bkjohnson
approved these changes
May 27, 2020
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR will upgrade
eslint-plugin-jsx-a11yandeslintto the latest versionThere are a lot of new rules and modifications to existing ones. They have been temporarily disabled until the update is complete.
Most of these rules will be evaluated and errors will be fixed before turn them on.
Testing done
Locally
Acceptance criteria
Definition of done