Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable no-unused-vars ESLint rule #13861

Merged
merged 28 commits into from
Aug 14, 2020
Merged

Enable no-unused-vars ESLint rule #13861

merged 28 commits into from
Aug 14, 2020

Conversation

bkjohnson
Copy link
Contributor

@bkjohnson bkjohnson commented Aug 13, 2020 •
edited
Loading

Description

This PR re-enables no-unused-vars which was disabled in #12760

We are tracking these disabled ESLint rules in department-of-veterans-affairs/va.gov-team#11691

There are a lot of changed files, but I've grouped the apps by commit (in a very loose alphabetical order by app). If you've viewed the changes in the commit for your app and they look good, then you can approve.

The following apps have 2 commits due to further changes after merging in master:

  • debt-letters
  • facility-locator
  • vaos
  • vre

Testing done

Only linting.

Screenshots

Turning the rule on before any of the fixes were made:

image

Acceptance criteria

  • [ ]

Definition of done

  • Events are logged appropriately
  • Documentation has been updated, if applicable
  • A link has been provided to the originating GitHub issue (or connected to it via ZenHub)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs

bkjohnson added 24 commits August 13, 2020 09:03
@bkjohnson
Turn no-unused-vars eslint rule back on
0c36702
@bkjohnson
Fix eslint errors in personalization app
b3d8776
@bkjohnson
Fix eslint errors in vaos app
53e3fb5
@bkjohnson
Fix eslint errors in static-pages
5ec2356
@bkjohnson
Fix eslint errors in vre/28-1900
2ea9a16
@bkjohnson
Fix eslint errors in gi app
3dea82d
@bkjohnson
Fix eslint errors in edu-benefits app
b1a6c45
@bkjohnson
Fix eslint errors in facility-locator
4ee5b8c
@bkjohnson
Fix eslint errors in disability-benefits
bcb6f16
@bkjohnson
Fix eslint errors in login app
f81ad9c
@bkjohnson
Fix eslint errors in coronavirus-screener app
0d9c31e
@bkjohnson
Fix eslint errors in debt-letters app
01194d4
@bkjohnson
Fix eslint errors in caregivers app
6304882
@bkjohnson
Fix eslint errors in platform/forms
0e40139
@bkjohnson
Fix eslint errors in platform/site-wide
061f31b
@bkjohnson
Fix eslint errors in vet360 & sso
ed62fc8
@bkjohnson
Fix eslint errors in CMS transformers
db678e3
@bkjohnson
Merge branch 'master' into enable-no-unused-vars
27e1a56
@bkjohnson
Fix eslint errors in covid-research-volunteer app
4fbf56a
@bkjohnson
Fix eslint errors in debt-letters - pt 2
70894f4
@bkjohnson
Fix eslint errors in facility-locator - pt 2
bb6924b
@bkjohnson
Fix eslint errorsin vaos - part 2
7ae3dba 
The error in the test file was from me messing up the merge, I think
@bkjohnson
Fix eslint errors in vre/1900 - pt 2
771be72
@bkjohnson
Disable no-unused-vars for DRUPAL_STAGING const
2405768 
This may be helpful to have - not sure why it isn't used
@va-vfs-bot va-vfs-bot requested a review from a team August 13, 2020 19:02
va-vfs-bot
va-vfs-bot reviewed Aug 13, 2020
View reviewed changes
Copy link

@va-vfs-bot va-vfs-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ESLint is disabled

vets-website uses ESLint to help enforce code quality. In most situations we would like ESLint to remain enabled.

What you can do

See if the code can be refactored to avoid disabling ESLint, or wait for a VSP review.

src/site/constants/drupals.js Show resolved Hide resolved
@bkjohnson bkjohnson marked this pull request as ready for review August 13, 2020 19:27
@bkjohnson bkjohnson requested review from a team as code owners August 13, 2020 19:27
@bkjohnson bkjohnson requested a review from a team as a code owner August 13, 2020 19:27
@bkjohnson bkjohnson requested a review from a team August 13, 2020 19:27
@bkjohnson bkjohnson requested review from a team as code owners August 13, 2020 19:27
erikphansen
erikphansen approved these changes Aug 13, 2020
View reviewed changes
Copy link
Contributor

@erikphansen erikphansen left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Geez, I can't believe how many unused vars made their way in since disabling that rule.

@va-vfs-bot va-vfs-bot temporarily deployed to master/enable-no-unused-vars August 13, 2020 20:41 Inactive
@mpelzsherman
Copy link
Contributor

Thanks for doing this painstaking work, @bkjohnson !!

@bkjohnson
Copy link
Contributor Author

@department-of-veterans-affairs/va-cto-health-products please review this as soon as you get the chance.

@va-vfs-bot va-vfs-bot temporarily deployed to master/enable-no-unused-vars August 14, 2020 16:34 Inactive
mchelen-gov
mchelen-gov approved these changes Aug 14, 2020
View reviewed changes
Copy link
Contributor

@mchelen-gov mchelen-gov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

src/applications/coronavirus-screener/ and src/applications/covid-research-volunteer/ look good

@bkjohnson bkjohnson merged commit a8d3585 into master Aug 14, 2020
@bkjohnson bkjohnson deleted the enable-no-unused-vars branch August 14, 2020 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@va-vfs-bot va-vfs-bot va-vfs-bot left review comments

@mchelen-gov mchelen-gov mchelen-gov approved these changes

@jhonnyoddball jhonnyoddball jhonnyoddball approved these changes

@erikphansen erikphansen erikphansen approved these changes

@micahchiang micahchiang micahchiang approved these changes

@bradl3yC bradl3yC bradl3yC approved these changes

@rianfowler rianfowler rianfowler approved these changes

@ncksllvn ncksllvn ncksllvn approved these changes

@zurbergram zurbergram zurbergram approved these changes

@jbalboni jbalboni jbalboni approved these changes

@Mottie Mottie Mottie approved these changes

@mpelzsherman mpelzsherman mpelzsherman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.