Remove Terms and Conditions

[ianmagenta]

Summary

Remove the old Terms & Conditions functionality from vets-website and ensure any code redirect to that page is also removed.

Related issue(s)

department-of-veterans-affairs/va.gov-team#53360

Acceptance criteria

• Remove the terms and conditions application from vets-website
• Notify in vfs-frontend & vfs-all-teams that Terms & Conditions application will be removed
• Ensure cta-widget that handles some MHV stuff does not redirect to terms & conditions

[asg5704]

Looks good, can you also create a PR to remove the app from the registry as well. Thank you!
https://github.com/department-of-veterans-affairs/content-build/blob/main/src/applications/registry.json

[adamwhitlock1]

We are currently linking to this application in the Profile application, and also showing specific information in account security based on the terms being accepted or not.

https://github.com/department-of-veterans-affairs/vets-website/blob/main/src/applications/personalization/profile/components/account-security/MHVTermsAndConditionsStatus.jsx#L7

Is there a replacement for this application, or should we just be removing this section of the Profile?

As it stands we would definitely be displaying broken links/causing issues once this app is removed if we don't mitigate first.

CC @BerniXiongA6 and @Samara-Strauss

[asg5704]

@adamwhitlock1 As far as I am aware the Terms & Conditions will be replaced at some point but the current T&C was created as bridge for MHV accounts interfaces that are no longer required. The section should probably be removed from the Profile until it is rebuilt. I have a PR that addresses the other parts of MHV Accounts creation & create and upgrade here #23438.

[jilladams]

Looks like Public Websites FE is marked as a required reviewer due to changes under /src/applications/static-pages (codeowner#L73).

The ticket for this PR (#53360) has no info on the business reasons for making the change, and it's in a general Identity Tech Debt epic, so I don't feel like we know enough to sign off on it, esp given Adam's feedback above. Platform COP Frontend is also marked as a required reviewer, so we'd like to let Platform FE be the ones to sign off on this unless folks have any objections.

[Samara-Strauss]

I asked in Slack as well, but has this been resolved?

[Samara-Strauss]

Lauren Alexanderson just posted this in slack:

Ultimately, we should not touch anything on T&C in VA.gov until the new T&C pathway is there, and then we do need to show users in profile that they have signed it, and give them a way to revoke signing it.

[rmessina1010]

LGTM

[asg5704]

Closing this until we can come back to it.