-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NuGet update failes when project path contains spaces. #8633
Comments
This is still not working as expected unfortunately |
Sorry to hear that; will reopen the issue and tagging @brettfo for awareness |
@TomW-Skyline Do you have a recent log file you can share? There are likely more places we need to surround arguments. |
@brettfo here is an example: |
@TomW-Skyline Added PR #9092 to allow proper execution of the tool with spaces in the command line. |
@brettfo That's great! There is probably no easy way to already test it? |
@TomW-Skyline I created a repo with a space in the path and did a full dependabot update run to verify the path fix. I've also just submitted #9104 which will fail a unit test on a malformed path so we can detect this faster. |
This probably doesn't entirely address dependabot#10527 but may be related. See also dependabot#8633.
The command arguments need to be surrounded by quotes, because otherwise there are problems when they contain spaces.
dependabot-core/nuget/lib/dependabot/nuget/native_helpers.rb
Line 57 in 89ebc55
The text was updated successfully, but these errors were encountered: