nuget updater command is already space-enabled; allow unsafe execution #9092
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The NuGet updater is invoked with already-escaped command line options, so we can simply call it with
allow_unsafe_shell_command: true
, otherwise the arguments are double escaped.Adding that parameter was the real fix, but I also refactored the code a bit to make testing the command line generation easier.
N.b., the helper function
run_shell_command
only takes a string which it tries to escape and that's where the problem arose; we have to pre-escape our strings to allow for a path with spaces in it, etc., and then tellrun_shell_command
that we've already escaped everything.Fixes #8633