Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't waste quota on main since branch was up-to-date #10352

Merged
merged 1 commit into from
Aug 2, 2024

Conversation

jakecoffman
Copy link
Member

@jakecoffman jakecoffman commented Aug 2, 2024

What are you trying to accomplish?

Lately we have been running out of API quota because the CI and smoke tests use tokens for testing.

Since we require branches to be up-to-date before merging, running these things on main is kind of pointless. So we can save quota by not running them again.

I know some of these workflows that I removed the main run from don't use the token, but again I don't see the point in running them on main if the branch was up-to-date.

Anything you want to highlight for special attention from reviewers?

Is my assumption above correct?

How will you know you've accomplished your goal?

Maybe we'll run out of quota less often.

Checklist

  • I have run the complete test suite to ensure all tests and linters pass.
  • I have thoroughly tested my code changes to ensure they work as expected, including adding additional tests for new functionality.
  • I have written clear and descriptive commit messages.
  • I have provided a detailed description of the changes in the pull request, including the problem it addresses, how it fixes the problem, and any relevant details about the implementation.
  • I have ensured that the code is well-documented and easy to understand.

@jakecoffman jakecoffman requested a review from a team as a code owner August 2, 2024 18:00
@jakecoffman jakecoffman merged commit 6ac2322 into main Aug 2, 2024
140 of 141 checks passed
@jakecoffman jakecoffman deleted the dont-run-stuff-on-main branch August 2, 2024 18:12
@JamieMagee JamieMagee mentioned this pull request Sep 20, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants