Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PR notices into the PR description created by UpdateAllVersions operation #10401

Conversation

kbukum1
Copy link
Contributor

@kbukum1 kbukum1 commented Aug 10, 2024

Description

What are you trying to accomplish?

Implementing a feature, #10399 to include generated PR notices into the PR which are created by the UpdateAllVersions operation. This ensures that important messages, warnings, and deprecations are clearly communicated in the PR description.

What issues does this affect or fix?

This enhancement adds the ability to pass generated PR notices into the PR message for update all versions, ensuring that relevant information is prominently displayed in the PR description. Currently, this includes the bundler v1 deprecation warning.

Anything you want to highlight for special attention from reviewers?

  • This PR extends the functionality of the UpdateAllVersions operation to include generated PR notices in the PR description.
  • The generated PR notices can include various types of messages such as informational messages, warnings, and errors to provide a comprehensive overview of the updates.
  • Since we generated bundler v1 deprecation warning, currently it is aiming to add this warning into the PR for bundler eco-system when PR is generated by bundler v1

How will you know you've accomplished your goal?

  • Demonstration: The generated PR notices, including the bundler v1 deprecation warning, should appear in the PR description for security updates, ensuring that all relevant information is clearly communicated.
Screenshot 2024-08-07 at 9 56 18 AM

Checklist

  • I have run the complete test suite to ensure all tests and linters pass.
  • I have thoroughly tested my code changes to ensure they work as expected, including adding additional tests for new functionality.
  • I have written clear and descriptive commit messages.
  • I have provided a detailed description of the changes in the pull request, including the problem it addresses, how it fixes the problem, and any relevant details about the implementation.
  • I have ensured that the code is well-documented and easy to understand.

@kbukum1 kbukum1 marked this pull request as ready for review August 10, 2024 01:28
@kbukum1 kbukum1 requested a review from a team as a code owner August 10, 2024 01:28
@kbukum1 kbukum1 self-assigned this Aug 12, 2024
@kbukum1 kbukum1 marked this pull request as draft August 12, 2024 20:58
@kbukum1 kbukum1 closed this Aug 13, 2024
@kbukum1
Copy link
Contributor Author

kbukum1 commented Aug 16, 2024

The feature implemented in the following PR, #10421

@kbukum1 kbukum1 deleted the kamil/add_pr_notices_to_update_all_versions_pr_description branch August 22, 2024 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant