Add Bundler v1 Deprecation Warning

[kbukum1]

What are you trying to accomplish?

The goal of this PR is to enhance the file parser to return the package_manager information directly. This change has been implemented for Bundler, and other package managers can have this feature added in the future. This information will be used to check for deprecation warnings specifically for Bundler v1.

What issues does this affect or fix?

This change allows us to better handle deprecation warnings for Bundler v1 by providing a consistent way to access package manager information directly from the file parser.

Anything you want to highlight for special attention from reviewers?

• The abstract package_manager method has been added to the base file parser.
• For Bundler, the package_manager method has been implemented and returns the necessary information for deprecation warnings.
• For other package managers, the package_manager method is currently not implemented but can be extended in the future.
• Ensure to review the implementation of the abstract method and its integration with the Bundler package manager.

How will you know you've accomplished your goal?

• The file parser will now return the package_manager information directly.
• The Bundler implementation correctly returns the package manager information.
• Deprecation warnings for Bundler v1 can be effectively checked using this new context.
• Tests should confirm that the new functionality works correctly and does not break existing functionality.

Checklist

• I have run the complete test suite to ensure all tests and linters pass.
• I have thoroughly tested my code changes to ensure they work as expected, including adding additional tests for new functionality.
• I have written clear and descriptive commit messages.
• I have provided a detailed description of the changes in the pull request, including the problem it addresses, how it fixes the problem, and any relevant details about the implementation.
• I have ensured that the code is well-documented and easy to understand.

[abdulapopoola]

I was wondering if as part of this effort we make these constants too?

[kbukum1]

I am currently keeping it as constants in bundler/package_manager. Do you mean something different since you are pointing in PackageManagerBase? Something like enum types?

[jakecoffman]

It seems like some unrelated changes like these and the types for all the methods have gotten into this PR? Try to keep extra changes out since it's already quite large of a change.

[kbukum1]

This change is just using variable to solve sorbet issue regarding dep.previous_requirements being not empty when passing to the dependency below. `requirements: dep.previous_requirements. If we don't use that we need to use T.must to tell the sorbet that it is not going to be empty.

[jakecoffman]

I'm not sure why we needed to fully type this file, it's better to keep a PR focussed on doing one thing. Often typing a file can cause unrelated problems. Partially typing new methods is preferred in this case.

[kbukum1]

I just replaced it to make it T.must since above we already have nil check.

[kbukum1]

I am currently keeping it as constants in bundler/package_manager. Do you mean something different since you are pointing in PackageManagerBase? Something like enum types?

[kbukum1]

This change is just using variable to solve sorbet issue regarding dep.previous_requirements being not empty when passing to the dependency below. `requirements: dep.previous_requirements. If we don't use that we need to use T.must to tell the sorbet that it is not going to be empty.

[jakecoffman]

Nice work!

You can run a CLI job with a Bundler 1 repo and the experiment enabled as a sanity test, if you haven't already.

[kbukum1]

Nice work!

You can run a CLI job with a Bundler 1 repo and the experiment enabled as a sanity test, if you haven't already.

Thanks this is be my first time for for enabling experience.