Pass the serialized group name when creating a PR for grouped updates #7166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brrygrdn
reviewed
Apr 25, 2023
Co-authored-by: Barry Gordon <896971+brrygrdn@users.noreply.github.com>
Nishnha
force-pushed
the
nishnha/pass-dependency-group-id-to-api
branch
from
99bef01
to
5529ce8
Compare
Co-authored-by: Barry Gordon <896971+brrygrdn@users.noreply.github.com>
Nishnha
force-pushed
the
nishnha/pass-dependency-group-id-to-api
branch
from
4e78793
to
f6916ee
Compare
|
I'll update the smoke-tests to use the new dependency-group key instead of grouped-update See dependabot/cli#102 for the CLI update that's required to update the smoke tests |
Nishnha
added a commit
to dependabot/cli
that referenced
this pull request
Apr 25, 2023
…d-update key Grouped updates now pass in the name of the group the PR was created with instead of a boolean grouped-update flag /xref dependabot/dependabot-core#7166
This was referenced Apr 25, 2023
Teach CreatePullRequest about the dependency-group key, remove grouped-update key
dependabot/cli#102
Merged
|
Opened dependabot/smoke-tests#61 for updating the smoke tests. The CLI changes need to be deployed first though |
Nishnha
added a commit
to dependabot/cli
that referenced
this pull request
Apr 25, 2023
…d-update key (#102) Grouped updates now pass in the name of the group the PR was created with instead of a boolean grouped-update flag /xref dependabot/dependabot-core#7166
brrygrdn
approved these changes
Apr 26, 2023
brettfo
pushed a commit
to brettfo/dependabot-core
that referenced
this pull request
Oct 11, 2023
…dency-group-id-to-api Pass the serialized group name when creating a PR for grouped updates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pass the serialized group name to PR creator (and the API client) when creating a PR for grouped updates.
We no longer pass the
grouped-updatekey to the PR creator and instead pass in thedependency-groupnameFor now we are transforming the group name to downcase, snake_case, and to a symbol (although the test checks the name after it's been serialized to JSON, so the DependencyChange#id is converted to a string)