Improve npm instrumentation #7177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffwidman
approved these changes
Apr 26, 2023
| package_manager.locked_version("yarn") || guess_yarn_version | ||
| end | ||
|
|
||
| def guess_yarn_version |
There was a problem hiding this comment.
now that is a function name that gives me confidence in what it does! 😁
It was checked, but not set.
These can be nil, so if we want to memoize them, we should do it properly.
jeffwidman
force-pushed
the
deivid-rodriguez/improve-npm-instrumentation
branch
from
0a6ff23
to
9d8333c
Compare
brettfo
pushed a commit
to brettfo/dependabot-core
that referenced
this pull request
Oct 11, 2023
…mprove-npm-instrumentation Improve npm instrumentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm still not totally sure that we should introduce the approach in #7134, but the little refactorings there should be good to introduce separately.