Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve npm instrumentation #7177

Merged
merged 7 commits into from
Apr 26, 2023
Merged

Improve npm instrumentation #7177

merged 7 commits into from
Apr 26, 2023

Commits on Apr 26, 2023

  1. Reuse parsed_package_json method

    @deivid-rodriguez @jeffwidman
    deivid-rodriguez authored and jeffwidman committed Apr 26, 2023
    Configuration menu
    Copy the full SHA
    e4f4176 View commit details
    Browse the repository at this point in the history

  2. Move logic to resolve package manager to separate class

    @deivid-rodriguez @jeffwidman
    deivid-rodriguez authored and jeffwidman committed Apr 26, 2023
    Configuration menu
    Copy the full SHA
    9f944ba View commit details
    Browse the repository at this point in the history

  3. Little refactor

    @deivid-rodriguez @jeffwidman
    deivid-rodriguez authored and jeffwidman committed Apr 26, 2023
    Configuration menu
    Copy the full SHA
    726669e View commit details
    Browse the repository at this point in the history

  4. Fix yarn version memoization 

    It was checked, but not set.
    @deivid-rodriguez @jeffwidman
    deivid-rodriguez authored and jeffwidman committed Apr 26, 2023
    Configuration menu
    Copy the full SHA
    50f98a5 View commit details
    Browse the repository at this point in the history

  5. Fix lockfile memoizations 

    These can be nil, so if we want to memoize them, we should do it
properly.
    @deivid-rodriguez @jeffwidman
    deivid-rodriguez authored and jeffwidman committed Apr 26, 2023
    Configuration menu
    Copy the full SHA
    3566b13 View commit details
    Browse the repository at this point in the history

  6. Check ignore package lock setting at a better place

    @deivid-rodriguez @jeffwidman
    deivid-rodriguez authored and jeffwidman committed Apr 26, 2023
    Configuration menu
    Copy the full SHA
    803ca3d View commit details
    Browse the repository at this point in the history

  7. Run yarn --version just once

    @deivid-rodriguez @jeffwidman
    deivid-rodriguez authored and jeffwidman committed Apr 26, 2023
    Configuration menu
    Copy the full SHA
    9d8333c View commit details
    Browse the repository at this point in the history