build(deps): bump npm from 9.5.1 to 9.6.5

[yeikel]

The latest version of Node 18 installs npm 9.6.7 but we need more information before we can proceed. See npm/cli#6742

In the meantime, I believe that it adds value to upgrade to 9.6.5 as we're behind

Closes #7659

[ghost]

R

[yeikel]

I am not sure if this TODO is appropriate or if I should create a separate dependabot-core issue instead

[yeikel]

@deivid-rodriguez @jeffwidman What do you recommend?

[jeffwidman]

I'm cool with either, especially as the TODO has an obvious location right next to the version string and right now we've chosen to focus on investing heavily into paying down tech debt on a few specific ecosystems rather than closely tracking issues.

Personally, I often tend to do both adding a TODO in code and then also adding an issue pointing at the TODO, but then I'm an overkill kind of guy for this sort of thing. 😁

What you've got is perfectly fine IMO. Also, the ones I really like to add TODOs for are the ones where we'll lose the context/realization that something needs to happen if a comment/issue isn't filed. The ones where it's like "down the road we'll realize the problem" are NBD IMO, and being behind on versions is one of them.

[yeikel]

Thanks, I'll leave it as is for now as that makes sense

I do agree that TODOs can become a problem if they don't have enough context as I see that often and most of the time the only context are commits from many years ago that makes it very hard to decide if that's still needed

[jeffwidman]

Some clarity on the TODO:

• [BUG] npm removes invalid references instead of failing with an error starting in 9.6.6  npm/cli#6742 (comment)

[yeikel]

The current failing spec seems flaky because I cannot reproduce it locally

This error also seems like a different bug but I do not know how to reproduce it :

Failure/Error:
@project_npm_response.body.force_encoding("UTF-8").encode.
include?(project_description)

 FrozenError:
   can't modify frozen String: ""

I am also seeing the same failure in #7908

[yeikel]

The current failing spec seems flaky because I cannot reproduce it locally

This error also seems like a different bug but I do not know how to reproduce it :

Failure/Error:
@project_npm_response.body.force_encoding("UTF-8").encode.
include?(project_description)

 FrozenError:
   can't modify frozen String: ""

I am also seeing the same failure in #7908

It seems that 4999e9b05cc62e5ad5c6331db87a3b40a17f2946 fixed it. Should I send a separate pull request for it?

[jeffwidman]

The current failing spec seems flaky because I cannot reproduce it locally
This error also seems like a different bug but I do not know how to reproduce it :

Failure/Error:
@project_npm_response.body.force_encoding("UTF-8").encode.
include?(project_description)

 FrozenError:
   can't modify frozen String: ""

I am also seeing the same failure in #7908

It seems that 4999e9b fixed it. Should I send a separate pull request for it?

Yes please, seeing as this likely exists on main, can you please break out a separate PR? That way if we revert this npm bump we won't lose it...

[yeikel]

The current failing spec seems flaky because I cannot reproduce it locally
This error also seems like a different bug but I do not know how to reproduce it :

Failure/Error:
@project_npm_response.body.force_encoding("UTF-8").encode.
include?(project_description)

 FrozenError:
   can't modify frozen String: ""

I am also seeing the same failure in #7908

It seems that 4999e9b fixed it. Should I send a separate pull request for it?

Yes please, seeing as this likely exists on main, can you please break out a separate PR? That way if we revert this npm bump we won't lose it...

Thanks, I dropped the commit from this branch and submitted this specific change with #7926

This branch is expected to continue failing until that is merged

[yeikel]

@jeffwidman After #7926 now this, #7899 and #7908 are ready to be reviewed

I don't have any rush though :)