build(deps): bump PNpm from 8.6.12 to 8.7.6 #7899
Conversation
yeikel
changed the title
yeikel
changed the title
yeikel
changed the title
| @@ -3978,7 +3978,7 @@ | |||
| it "updates the manifest and lockfile" do | |||
| expect(updated_files.map(&:name)).to match_array(%w(package.json pnpm-lock.yaml)) | |||
|
|
|||
| expect(updated_pnpm_lock.content).to include("/node-adodb@5.0.2:") | |||
| expect(updated_pnpm_lock.content).to include("/node-adodb@5.0.3:") | |||
There was a problem hiding this comment.
This is the result of the following change :
The default value of the resolution-mode setting is changed to highest. This setting was changed to lowest-direct in v8.0.0 and some users were not happy with the change. A twitter poll concluded that most of the users want the old behaviour (resolution-mode set to highest by default). This is a semi-breaking change but should not affect users that commit their lockfile #6463.
There was a problem hiding this comment.
@deivid-rodriguez Your input would be appreciated here 🙇
There was a problem hiding this comment.
_deivid-rodriguez just headed out on holiday and will be offline for a few weeks (I think he might be 🚴 ?)
But I agree it'd be good to get his input on this, so if no one else on the team picks this up and you don't hear from him by Sept 20th, feel free to ping him again.
There was a problem hiding this comment.
That sounds fine @yeikel, but we may want to make the test resilient to new releases of this dependency. Maybe by using an exact dependency? This test claims to be dealing with incorrect platform dependencies, so I guess such as change would not affect that?
There was a problem hiding this comment.
Given the feedback that they received, I do not expect this to change again anytime soon
There was a problem hiding this comment.
@deivid-rodriguez What do you suggest we do now?
There was a problem hiding this comment.
Do you mean you don't expect upstream PNPM to change default resolution mode again soon, or you don't expect node-adodb to release 5.0.4 anytime soon?
My suggestion was aimed at making this spec resilient to a potential release of node-adodb 5.0.4.
yeikel
force-pushed
the
patch-7
branch
2 times, most recently
from
d525c70 to
82d69c9
Compare
yeikel
force-pushed
the
patch-7
branch
3 times, most recently
from
29fe388 to
fb5d3c6
Compare
yeikel
changed the title
yeikel
force-pushed
the
patch-7
branch
3 times, most recently
from
3f5fb62 to
8dd57dc
Compare
yeikel
changed the title
yeikel
changed the title
yeikel
force-pushed
the
patch-7
branch
4 times, most recently
from
2c20b86 to
bf34d59
Compare
yeikel
changed the title
yeikel
force-pushed
the
patch-7
branch
2 times, most recently
from
4edec5f to
4c0aad6
Compare
yeikel
changed the title
yeikel
force-pushed
the
patch-7
branch
5 times, most recently
from
bf741a4 to
a2744c9
Compare
Release notes: https://github.com/pnpm/pnpm/releases/tag/v8.7.0 https://github.com/pnpm/pnpm/releases/tag/v8.7.1 https://github.com/pnpm/pnpm/releases/tag/v8.7.2 https://github.com/pnpm/pnpm/releases/tag/v8.7.3 https://github.com/pnpm/pnpm/releases/tag/v8.7.4 https://github.com/pnpm/pnpm/releases/tag/v8.7.5 https://github.com/pnpm/pnpm/releases/tag/v8.7.6
|
Thanks @yeikel! |
I was about to work on the tests you recommended. Sorry about the delay I'll send that in a follow up PR sometime this week |
|
No problem, thanks as always for your contributions and patience! |
Release notes:
https://github.com/pnpm/pnpm/releases/tag/v8.7.0
https://github.com/pnpm/pnpm/releases/tag/v8.7.1
https://github.com/pnpm/pnpm/releases/tag/v8.7.2
https://github.com/pnpm/pnpm/releases/tag/v8.7.3
https://github.com/pnpm/pnpm/releases/tag/v8.7.4
https://github.com/pnpm/pnpm/releases/tag/v8.7.5
https://github.com/pnpm/pnpm/releases/tag/v8.7.6