Add workflow for creating release PR's #360

jeffwidman · 2023-05-17T08:41:08Z

Add a workflow for creating release PR's. This way we don't have to do it locally, and we guarantee the npm version used to generate the version bump is consistent and stays in-sync with the repo instead of whatever the dev happened to have on their local computer.

jeffwidman

Annotating the changes

bin/bump-version

.github/workflows/release-bump-version.yml

Over in #360 (comment), I noticed that bash was complaining about this script: ```bash bin/bump-version: line 9: ((: patch_level == 'major' || patch_level == 'minor' || patch_level == 'patch': syntax error: operand expected (error token is "'major' || patch_level == 'minor' || patch_level == 'patch'") ``` I started to dig into it, but the `while` loop isn't needed, the `case` statement felt unecessarily complex so I simplified it to use an `if` statement. I also changed the argument from a flag-based argument to simple ordered argument, as again it seemed simpler and it matches the style of the bump version script over in `dependabot-core` so it's easier for engineers working across repos. Lastly, I found `patch_version` confusing given that `patch` is a specific value that can be used, so I renamed it to `version_type`.

Over in #360 (comment), I noticed that bash was complaining about this script: ```bash bin/bump-version: line 9: ((: patch_level == 'major' || patch_level == 'minor' || patch_level == 'patch': syntax error: operand expected (error token is "'major' || patch_level == 'minor' || patch_level == 'patch'") ``` I started to dig into it, but the `while` loop isn't needed, the `case` statement felt unecessarily complex so I simplified it to use an `if` statement. I also changed the argument from a flag-based argument to simple ordered argument, as again it seemed simpler and it matches the style of the bump version script over in `dependabot-core` so it's easier for engineers working across repos. If we later have additional flags, we can always switch it back later. Lastly, I found `patch_version` confusing given that `patch` is a specific value that can be used, so I renamed it to `version_type`.

Add a workflow for creating release PR's. This way we don't have to do it locally, and we guarantee the `npm` version used to generate the version bump is consistent and stays in-sync with the repo instead of whatever the dev happened to have on their local computer.

Nishnha

Thanks for adding this workflow!
This lgtm.
I see that there's a manual step to tag the merge commit... I wonder if we could automate that too?

jeffwidman · 2023-05-18T18:55:44Z

I see that there's a manual step to tag the merge commit... I wonder if we could automate that too?

You mean like:

Add workflow for floating the v1 tag to the latest release #361

😀

jeffwidman requested a review from a team as a code owner May 17, 2023 08:41

jeffwidman force-pushed the add-workflow-for-creating-release-PR branch from b47cd51 to e029e85 Compare May 17, 2023 08:42

jeffwidman commented May 17, 2023

View reviewed changes

bin/bump-version Outdated Show resolved Hide resolved

bin/bump-version Show resolved Hide resolved

.github/workflows/release-bump-version.yml Outdated Show resolved Hide resolved

jeffwidman force-pushed the add-workflow-for-creating-release-PR branch 3 times, most recently from 069b181 to 0cbbe35 Compare May 18, 2023 16:39

jeffwidman mentioned this pull request May 18, 2023

Simplify bin/bump-version #368

Merged

jeffwidman force-pushed the add-workflow-for-creating-release-PR branch 5 times, most recently from d212fb3 to 4c69d3c Compare May 18, 2023 18:06

jeffwidman force-pushed the add-workflow-for-creating-release-PR branch from 4c69d3c to 86de090 Compare May 18, 2023 18:34

Nishnha approved these changes May 18, 2023

View reviewed changes

jeffwidman merged commit 6c5b8c2 into main May 18, 2023

jeffwidman deleted the add-workflow-for-creating-release-PR branch May 18, 2023 18:56

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add workflow for creating release PR's #360

Add workflow for creating release PR's #360

jeffwidman commented May 17, 2023

jeffwidman left a comment

Nishnha left a comment

jeffwidman commented May 18, 2023

Add workflow for creating release PR's #360

Add workflow for creating release PR's #360

Conversation

jeffwidman commented May 17, 2023

jeffwidman left a comment

Choose a reason for hiding this comment

Nishnha left a comment

Choose a reason for hiding this comment

jeffwidman commented May 18, 2023