-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify bin/bump-version
#368
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brrygrdn
approved these changes
May 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏻
jeffwidman
force-pushed
the
simplify-the-bump-version-script
branch
from
May 18, 2023 17:21
8dae82e
to
6d73f7a
Compare
Over in #360 (comment), I noticed that bash was complaining about this script: ```bash bin/bump-version: line 9: ((: patch_level == 'major' || patch_level == 'minor' || patch_level == 'patch': syntax error: operand expected (error token is "'major' || patch_level == 'minor' || patch_level == 'patch'") ``` I started to dig into it, but the `while` loop isn't needed, the `case` statement felt unecessarily complex so I simplified it to use an `if` statement. I also changed the argument from a flag-based argument to simple ordered argument, as again it seemed simpler and it matches the style of the bump version script over in `dependabot-core` so it's easier for engineers working across repos. If we later have additional flags, we can always switch it back later. Lastly, I found `patch_version` confusing given that `patch` is a specific value that can be used, so I renamed it to `version_type`.
jeffwidman
force-pushed
the
simplify-the-bump-version-script
branch
from
May 18, 2023 17:23
6d73f7a
to
3765acd
Compare
ilkka
referenced
this pull request
in ilkka/nisse
Sep 20, 2023
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [dependabot/fetch-metadata](https://github.com/dependabot/fetch-metadata) | action | minor | `v1.3.1` -> `v1.6.0` | --- ### Release Notes <details> <summary>dependabot/fetch-metadata (dependabot/fetch-metadata)</summary> ### [`v1.6.0`](https://github.com/dependabot/fetch-metadata/releases/tag/v1.6.0) [Compare Source](https://github.com/dependabot/fetch-metadata/compare/v1.5.1...v1.6.0) #### What's Changed - Add `.vscode` folder to `.gitignore` by [@​timothy-humphrey](https://github.com/timothy-humphrey) in [https://github.com/dependabot/fetch-metadata/pull/385](https://github.com/dependabot/fetch-metadata/pull/385) - Support for Grouped Updates by [@​Nishnha](https://github.com/Nishnha) in [https://github.com/dependabot/fetch-metadata/pull/396](https://github.com/dependabot/fetch-metadata/pull/396) - v1.6.0 by [@​fetch-metadata-action-automation](https://github.com/fetch-metadata-action-automation) in [https://github.com/dependabot/fetch-metadata/pull/403](https://github.com/dependabot/fetch-metadata/pull/403) #### New Contributors - [@​timothy-humphrey](https://github.com/timothy-humphrey) made their first contribution in [https://github.com/dependabot/fetch-metadata/pull/385](https://github.com/dependabot/fetch-metadata/pull/385) **Full Changelog**: dependabot/fetch-metadata@v1...v1.6.0 ### [`v1.5.1`](https://github.com/dependabot/fetch-metadata/releases/tag/v1.5.1) [Compare Source](https://github.com/dependabot/fetch-metadata/compare/v1.5.0...v1.5.1) #### What's Changed Bugfix: - Fix library parser to trim trailing LF by [@​kachick](https://github.com/kachick) in [https://github.com/dependabot/fetch-metadata/pull/380](https://github.com/dependabot/fetch-metadata/pull/380) Dep bumps that are trivial so decided to keep this a patch release: - Bump yargs from 17.7.1 to 17.7.2 by [@​dependabot](https://github.com/dependabot) in [https://github.com/dependabot/fetch-metadata/pull/379](https://github.com/dependabot/fetch-metadata/pull/379) - Bump [@​types/node](https://github.com/types/node) from 20.2.1 to 20.2.3 by [@​dependabot](https://github.com/dependabot) in [https://github.com/dependabot/fetch-metadata/pull/382](https://github.com/dependabot/fetch-metadata/pull/382) Internal-facing infra changes: - Group PR's for `eslint`-related deps by [@​jeffwidman](https://github.com/jeffwidman) in [https://github.com/dependabot/fetch-metadata/pull/374](https://github.com/dependabot/fetch-metadata/pull/374) - Bump the eslint-dependencies group with 3 updates by [@​dependabot](https://github.com/dependabot) in [https://github.com/dependabot/fetch-metadata/pull/375](https://github.com/dependabot/fetch-metadata/pull/375) - Bump the eslint-dependencies group with 2 updates by [@​dependabot](https://github.com/dependabot) in [https://github.com/dependabot/fetch-metadata/pull/378](https://github.com/dependabot/fetch-metadata/pull/378) - Switch to using an app token instead of a PAT by [@​jeffwidman](https://github.com/jeffwidman) in [https://github.com/dependabot/fetch-metadata/pull/362](https://github.com/dependabot/fetch-metadata/pull/362) - v1.5.1 by [@​fetch-metadata-action-automation](https://github.com/fetch-metadata-action-automation) in [https://github.com/dependabot/fetch-metadata/pull/384](https://github.com/dependabot/fetch-metadata/pull/384) **Full Changelog**: dependabot/fetch-metadata@v1...v1.5.1 ### [`v1.5.0`](https://github.com/dependabot/fetch-metadata/releases/tag/v1.5.0) [Compare Source](https://github.com/dependabot/fetch-metadata/compare/v1.4.0...v1.5.0) #### What's Changed New Features: - Added flag if "Maintainer changes" appears in the PR body by [@​mwaddell](https://github.com/mwaddell) in [https://github.com/dependabot/fetch-metadata/pull/174](https://github.com/dependabot/fetch-metadata/pull/174) Bumped Deps: - Bump [@​types/node](https://github.com/types/node) from 18.15.11 to 20.2.1 by [@​dependabot](https://github.com/dependabot) in [https://github.com/dependabot/fetch-metadata/pull/364](https://github.com/dependabot/fetch-metadata/pull/364) - Bump nock from 13.3.0 to 13.3.1 by [@​dependabot](https://github.com/dependabot) in [https://github.com/dependabot/fetch-metadata/pull/366](https://github.com/dependabot/fetch-metadata/pull/366) Docs: - Add minimum permissions to usage example by [@​jablko](https://github.com/jablko) in [https://github.com/dependabot/fetch-metadata/pull/343](https://github.com/dependabot/fetch-metadata/pull/343) - Document verification overrides in readme by [@​jeffwidman](https://github.com/jeffwidman) in [https://github.com/dependabot/fetch-metadata/pull/345](https://github.com/dependabot/fetch-metadata/pull/345) Code cleanup: - Simplify the release process by linking to release notes instead of copy/pasting them by [@​jeffwidman](https://github.com/jeffwidman) in [https://github.com/dependabot/fetch-metadata/pull/347](https://github.com/dependabot/fetch-metadata/pull/347) - Use the full email for the GitHub Actions bot by [@​jeffwidman](https://github.com/jeffwidman) in [https://github.com/dependabot/fetch-metadata/pull/354](https://github.com/dependabot/fetch-metadata/pull/354) - Inline the PR URL by [@​jeffwidman](https://github.com/jeffwidman) in [https://github.com/dependabot/fetch-metadata/pull/359](https://github.com/dependabot/fetch-metadata/pull/359) - No need to request escalated permissions for `GITHUB_TOKEN` by [@​jeffwidman](https://github.com/jeffwidman) in [https://github.com/dependabot/fetch-metadata/pull/357](https://github.com/dependabot/fetch-metadata/pull/357) - Remove unused step by [@​jeffwidman](https://github.com/jeffwidman) in [https://github.com/dependabot/fetch-metadata/pull/358](https://github.com/dependabot/fetch-metadata/pull/358) - Simplify `bin/bump-version` by [@​jeffwidman](https://github.com/jeffwidman) in [https://github.com/dependabot/fetch-metadata/pull/368](https://github.com/dependabot/fetch-metadata/pull/368) - Add a deeplink for tagging releases to the Readme by [@​jeffwidman](https://github.com/jeffwidman) in [https://github.com/dependabot/fetch-metadata/pull/369](https://github.com/dependabot/fetch-metadata/pull/369) - Stop using deprecated `set-output` by [@​jeffwidman](https://github.com/jeffwidman) in [https://github.com/dependabot/fetch-metadata/pull/370](https://github.com/dependabot/fetch-metadata/pull/370) - Add workflow for creating release PR's by [@​jeffwidman](https://github.com/jeffwidman) in [https://github.com/dependabot/fetch-metadata/pull/360](https://github.com/dependabot/fetch-metadata/pull/360) - Add workflow for floating the `v1` tag to the latest release by [@​jeffwidman](https://github.com/jeffwidman) in [https://github.com/dependabot/fetch-metadata/pull/361](https://github.com/dependabot/fetch-metadata/pull/361) **Full Changelog**: dependabot/fetch-metadata@v1...v1.5.0 ### [`v1.4.0`](https://github.com/dependabot/fetch-metadata/releases/tag/v1.4.0) [Compare Source](https://github.com/dependabot/fetch-metadata/compare/v1.3.6...v1.4.0) #### New Features - feat: add option to skip internal verifications by [@​yeikel](https://github.com/yeikel) in [https://github.com/dependabot/fetch-metadata/pull/336](https://github.com/dependabot/fetch-metadata/pull/336) #### Bugfix - Allow leading `v` on commit message versions by [@​jonmcquillan](https://github.com/jonmcquillan) in [https://github.com/dependabot/fetch-metadata/pull/338](https://github.com/dependabot/fetch-metadata/pull/338) #### Dep Bumps - Bump [@​typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/eslint-plugin) from 5.48.2 to 5.49.0 by [@​dependabot](https://github.com/dependabot) in [https://github.com/dependabot/fetch-metadata/pull/307](https://github.com/dependabot/fetch-metadata/pull/307) - Bump [@​types/yargs](https://github.com/types/yargs) from 17.0.19 to 17.0.20 by [@​dependabot](https://github.com/dependabot) in [https://github.com/dependabot/fetch-metadata/pull/308](https://github.com/dependabot/fetch-metadata/pull/308) - Bump [@​typescript-eslint/parser](https://github.com/typescript-eslint/parser) from 5.48.2 to 5.49.0 by [@​dependabot](https://github.com/dependabot) in [https://github.com/dependabot/fetch-metadata/pull/309](https://github.com/dependabot/fetch-metadata/pull/309) - Bump eslint from 8.32.0 to 8.33.0 by [@​dependabot](https://github.com/dependabot) in [https://github.com/dependabot/fetch-metadata/pull/315](https://github.com/dependabot/fetch-metadata/pull/315) - Bump [@​typescript-eslint/parser](https://github.com/typescript-eslint/parser) from 5.49.0 to 5.50.0 by [@​dependabot](https://github.com/dependabot) in [https://github.com/dependabot/fetch-metadata/pull/314](https://github.com/dependabot/fetch-metadata/pull/314) - Bump [@​types/yargs](https://github.com/types/yargs) from 17.0.20 to 17.0.22 by [@​dependabot](https://github.com/dependabot) in [https://github.com/dependabot/fetch-metadata/pull/312](https://github.com/dependabot/fetch-metadata/pull/312) - Bump [@​vercel/ncc](https://github.com/vercel/ncc) from 0.36.0 to 0.36.1 by [@​dependabot](https://github.com/dependabot) in [https://github.com/dependabot/fetch-metadata/pull/311](https://github.com/dependabot/fetch-metadata/pull/311) - Bump typescript from 4.9.4 to 4.9.5 by [@​dependabot](https://github.com/dependabot) in [https://github.com/dependabot/fetch-metadata/pull/313](https://github.com/dependabot/fetch-metadata/pull/313) - Bump yargs from 17.6.2 to 17.7.1 by [@​dependabot](https://github.com/dependabot) in [https://github.com/dependabot/fetch-metadata/pull/322](https://github.com/dependabot/fetch-metadata/pull/322) - Bump eslint from 8.33.0 to 8.35.0 by [@​dependabot](https://github.com/dependabot) in [https://github.com/dependabot/fetch-metadata/pull/321](https://github.com/dependabot/fetch-metadata/pull/321) - Bump [@​typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/eslint-plugin) from 5.49.0 to 5.54.0 by [@​dependabot](https://github.com/dependabot) in [https://github.com/dependabot/fetch-metadata/pull/319](https://github.com/dependabot/fetch-metadata/pull/319) - Bump [@​typescript-eslint/parser](https://github.com/typescript-eslint/parser) from 5.50.0 to 5.54.0 by [@​dependabot](https://github.com/dependabot) in [https://github.com/dependabot/fetch-metadata/pull/320](https://github.com/dependabot/fetch-metadata/pull/320) - Bump [@​types/node](https://github.com/types/node) from 18.11.18 to 18.14.2 by [@​dependabot](https://github.com/dependabot) in [https://github.com/dependabot/fetch-metadata/pull/318](https://github.com/dependabot/fetch-metadata/pull/318) - Bump [@​types/node](https://github.com/types/node) from 18.14.2 to 18.15.11 by [@​dependabot](https://github.com/dependabot) in [https://github.com/dependabot/fetch-metadata/pull/324](https://github.com/dependabot/fetch-metadata/pull/324) - Bump eslint from 8.35.0 to 8.37.0 by [@​dependabot](https://github.com/dependabot) in [https://github.com/dependabot/fetch-metadata/pull/327](https://github.com/dependabot/fetch-metadata/pull/327) - Bump [@​types/yargs](https://github.com/types/yargs) from 17.0.22 to 17.0.24 by [@​dependabot](https://github.com/dependabot) in [https://github.com/dependabot/fetch-metadata/pull/326](https://github.com/dependabot/fetch-metadata/pull/326) - Bump [@​typescript-eslint/parser](https://github.com/typescript-eslint/parser) from 5.54.0 to 5.57.1 by [@​dependabot](https://github.com/dependabot) in [https://github.com/dependabot/fetch-metadata/pull/330](https://github.com/dependabot/fetch-metadata/pull/330) - Bump [@​typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/eslint-plugin) from 5.54.0 to 5.57.1 by [@​dependabot](https://github.com/dependabot) in [https://github.com/dependabot/fetch-metadata/pull/329](https://github.com/dependabot/fetch-metadata/pull/329) - Bump eslint from 8.37.0 to 8.38.0 by [@​dependabot](https://github.com/dependabot) in [https://github.com/dependabot/fetch-metadata/pull/340](https://github.com/dependabot/fetch-metadata/pull/340) - Bump [@​typescript-eslint/parser](https://github.com/typescript-eslint/parser) from 5.57.1 to 5.59.0 by [@​dependabot](https://github.com/dependabot) in [https://github.com/dependabot/fetch-metadata/pull/341](https://github.com/dependabot/fetch-metadata/pull/341) - Bump [@​typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/eslint-plugin) from 5.57.1 to 5.59.0 by [@​dependabot](https://github.com/dependabot) in [https://github.com/dependabot/fetch-metadata/pull/342](https://github.com/dependabot/fetch-metadata/pull/342) #### Other - chore(ee): add devcontainer by [@​yeikel](https://github.com/yeikel) in [https://github.com/dependabot/fetch-metadata/pull/337](https://github.com/dependabot/fetch-metadata/pull/337) #### New Contributors - [@​jonmcquillan](https://github.com/jonmcquillan) made their first contribution in [https://github.com/dependabot/fetch-metadata/pull/338](https://github.com/dependabot/fetch-metadata/pull/338) - [@​yeikel](https://github.com/yeikel) made their first contribution in [https://github.com/dependabot/fetch-metadata/pull/337](https://github.com/dependabot/fetch-metadata/pull/337) **Full Changelog**: dependabot/fetch-metadata@v1...v1.4.0 ### [`v1.3.6`](https://github.com/dependabot/fetch-metadata/releases/tag/v1.3.6) [Compare Source](https://github.com/dependabot/fetch-metadata/compare/v1.3.5...v1.3.6) #### What's Changed - Drop mention of "locally" by [@​jeffwidman](https://github.com/jeffwidman) in [https://github.com/dependabot/fetch-metadata/pull/281](https://github.com/dependabot/fetch-metadata/pull/281) - Don't assume `git pull` fetches all branches/tags by [@​jeffwidman](https://github.com/jeffwidman) in [https://github.com/dependabot/fetch-metadata/pull/284](https://github.com/dependabot/fetch-metadata/pull/284) - Clarify release notes slightly by [@​jeffwidman](https://github.com/jeffwidman) in [https://github.com/dependabot/fetch-metadata/pull/283](https://github.com/dependabot/fetch-metadata/pull/283) - Bump eslint-plugin-promise from 6.0.1 to 6.1.1 by [@​dependabot](https://github.com/dependabot) in [https://github.com/dependabot/fetch-metadata/pull/287](https://github.com/dependabot/fetch-metadata/pull/287) - Bump [@​typescript-eslint/parser](https://github.com/typescript-eslint/parser) from 5.38.0 to 5.45.0 by [@​dependabot](https://github.com/dependabot) in [https://github.com/dependabot/fetch-metadata/pull/290](https://github.com/dependabot/fetch-metadata/pull/290) - Bump yargs and [@​types/yargs](https://github.com/types/yargs) by [@​dependabot](https://github.com/dependabot) in [https://github.com/dependabot/fetch-metadata/pull/286](https://github.com/dependabot/fetch-metadata/pull/286) - Bump [@​types/node](https://github.com/types/node) from 18.11.9 to 18.11.10 by [@​dependabot](https://github.com/dependabot) in [https://github.com/dependabot/fetch-metadata/pull/289](https://github.com/dependabot/fetch-metadata/pull/289) - Bump decode-uri-component from 0.2.0 to 0.2.2 by [@​dependabot](https://github.com/dependabot) in [https://github.com/dependabot/fetch-metadata/pull/291](https://github.com/dependabot/fetch-metadata/pull/291) - Bump yaml from 2.1.1 to 2.1.3 by [@​dependabot](https://github.com/dependabot) in [https://github.com/dependabot/fetch-metadata/pull/288](https://github.com/dependabot/fetch-metadata/pull/288) - Bump [@​types/node](https://github.com/types/node) from 18.11.10 to 18.11.18 by [@​dependabot](https://github.com/dependabot) in [https://github.com/dependabot/fetch-metadata/pull/296](https://github.com/dependabot/fetch-metadata/pull/296) - Bump [@​vercel/ncc](https://github.com/vercel/ncc) from 0.34.0 to 0.36.0 by [@​dependabot](https://github.com/dependabot) in [https://github.com/dependabot/fetch-metadata/pull/294](https://github.com/dependabot/fetch-metadata/pull/294) - Bump dotenv from 16.0.2 to 16.0.3 by [@​dependabot](https://github.com/dependabot) in [https://github.com/dependabot/fetch-metadata/pull/293](https://github.com/dependabot/fetch-metadata/pull/293) - Bump typescript from 4.8.3 to 4.9.4 by [@​dependabot](https://github.com/dependabot) in [https://github.com/dependabot/fetch-metadata/pull/295](https://github.com/dependabot/fetch-metadata/pull/295) - Bump yaml from 2.1.3 to 2.2.1 by [@​dependabot](https://github.com/dependabot) in [https://github.com/dependabot/fetch-metadata/pull/292](https://github.com/dependabot/fetch-metadata/pull/292) - Bump json5 from 1.0.1 to 1.0.2 by [@​dependabot](https://github.com/dependabot) in [https://github.com/dependabot/fetch-metadata/pull/297](https://github.com/dependabot/fetch-metadata/pull/297) - Bump eslint from 8.23.1 to 8.32.0 by [@​dependabot](https://github.com/dependabot) in [https://github.com/dependabot/fetch-metadata/pull/303](https://github.com/dependabot/fetch-metadata/pull/303) - Bump [@​typescript-eslint/parser](https://github.com/typescript-eslint/parser) from 5.45.0 to 5.48.2 by [@​dependabot](https://github.com/dependabot) in [https://github.com/dependabot/fetch-metadata/pull/300](https://github.com/dependabot/fetch-metadata/pull/300) - Bump [@​typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/eslint-plugin) from 5.42.0 to 5.48.2 by [@​dependabot](https://github.com/dependabot) in [https://github.com/dependabot/fetch-metadata/pull/302](https://github.com/dependabot/fetch-metadata/pull/302) - Bump eslint-plugin-import from 2.26.0 to 2.27.5 by [@​dependabot](https://github.com/dependabot) in [https://github.com/dependabot/fetch-metadata/pull/301](https://github.com/dependabot/fetch-metadata/pull/301) - Bump nock from 13.2.9 to 13.3.0 by [@​dependabot](https://github.com/dependabot) in [https://github.com/dependabot/fetch-metadata/pull/299](https://github.com/dependabot/fetch-metadata/pull/299) - Bump [@​types/yargs](https://github.com/types/yargs) from 17.0.15 to 17.0.19 by [@​dependabot](https://github.com/dependabot) in [https://github.com/dependabot/fetch-metadata/pull/304](https://github.com/dependabot/fetch-metadata/pull/304) - Fix parser for libraries by [@​kachick](https://github.com/kachick) in [https://github.com/dependabot/fetch-metadata/pull/224](https://github.com/dependabot/fetch-metadata/pull/224) #### New Contributors - [@​kachick](https://github.com/kachick) made their first contribution in [https://github.com/dependabot/fetch-metadata/pull/224](https://github.com/dependabot/fetch-metadata/pull/224) **Full Changelog**: dependabot/fetch-metadata@v1...v1.3.6 ### [`v1.3.5`](https://github.com/dependabot/fetch-metadata/releases/tag/v1.3.5) [Compare Source](https://github.com/dependabot/fetch-metadata/compare/v1.3.4...v1.3.5) #### What's Changed - v1.3.4 Release Notes by [@​Nishnha](https://github.com/Nishnha) in [https://github.com/dependabot/fetch-metadata/pull/267](https://github.com/dependabot/fetch-metadata/pull/267) - docs: fix auto-merge example by [@​rribeiro1](https://github.com/rribeiro1) in [https://github.com/dependabot/fetch-metadata/pull/250](https://github.com/dependabot/fetch-metadata/pull/250) - Bump [@​types/node](https://github.com/types/node) from 18.7.18 to 18.11.9 by [@​dependabot](https://github.com/dependabot) in [https://github.com/dependabot/fetch-metadata/pull/275](https://github.com/dependabot/fetch-metadata/pull/275) - Fix object-shorthand linter warnings by [@​mattt](https://github.com/mattt) in [https://github.com/dependabot/fetch-metadata/pull/276](https://github.com/dependabot/fetch-metadata/pull/276) - Bump [@​actions/core](https://github.com/actions/core) from 1.9.1 to 1.10.0 by [@​dependabot](https://github.com/dependabot) in [https://github.com/dependabot/fetch-metadata/pull/272](https://github.com/dependabot/fetch-metadata/pull/272) - Bump [@​typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/eslint-plugin) from 5.38.0 to 5.42.0 by [@​dependabot](https://github.com/dependabot) in [https://github.com/dependabot/fetch-metadata/pull/274](https://github.com/dependabot/fetch-metadata/pull/274) - Bump [@​actions/github](https://github.com/actions/github) from 5.0.3 to 5.1.1 by [@​dependabot](https://github.com/dependabot) in [https://github.com/dependabot/fetch-metadata/pull/271](https://github.com/dependabot/fetch-metadata/pull/271) - Bump yargs and [@​types/yargs](https://github.com/types/yargs) by [@​dependabot](https://github.com/dependabot) in [https://github.com/dependabot/fetch-metadata/pull/273](https://github.com/dependabot/fetch-metadata/pull/273) - Document steps for cutting a new release by [@​jeffwidman](https://github.com/jeffwidman) in [https://github.com/dependabot/fetch-metadata/pull/252](https://github.com/dependabot/fetch-metadata/pull/252) - Don't bump pin versions in `README.md` by [@​jeffwidman](https://github.com/jeffwidman) in [https://github.com/dependabot/fetch-metadata/pull/280](https://github.com/dependabot/fetch-metadata/pull/280) #### New Contributors - [@​Nishnha](https://github.com/Nishnha) made their first contribution in [https://github.com/dependabot/fetch-metadata/pull/267](https://github.com/dependabot/fetch-metadata/pull/267) - [@​rribeiro1](https://github.com/rribeiro1) made their first contribution in [https://github.com/dependabot/fetch-metadata/pull/250](https://github.com/dependabot/fetch-metadata/pull/250) **Full Changelog**: dependabot/fetch-metadata@v1...v1.3.5 ### [`v1.3.4`](https://github.com/dependabot/fetch-metadata/releases/tag/v1.3.4) [Compare Source](https://github.com/dependabot/fetch-metadata/compare/v1.3.3...v1.3.4) #### What's Changed - Pin only to major version, not full patch version by [@​jeffwidman](https://github.com/jeffwidman) in [https://github.com/dependabot/fetch-metadata/pull/246](https://github.com/dependabot/fetch-metadata/pull/246) - Fix broken logo on readme by [@​jeffwidman](https://github.com/jeffwidman) in [https://github.com/dependabot/fetch-metadata/pull/253](https://github.com/dependabot/fetch-metadata/pull/253) - Bump action to use node16 by [@​quinnjn](https://github.com/quinnjn) in [https://github.com/dependabot/fetch-metadata/pull/251](https://github.com/dependabot/fetch-metadata/pull/251) - Bump [@​typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/eslint-plugin) from 5.20.0 to 5.38.0 by [@​dependabot](https://github.com/dependabot) in [https://github.com/dependabot/fetch-metadata/pull/256](https://github.com/dependabot/fetch-metadata/pull/256) - Bump [@​actions/core](https://github.com/actions/core) from 1.6.0 to 1.9.1 by [@​dependabot](https://github.com/dependabot) in [https://github.com/dependabot/fetch-metadata/pull/242](https://github.com/dependabot/fetch-metadata/pull/242) - Bump eslint-config-standard from 16.0.3 to 17.0.0 by [@​dependabot](https://github.com/dependabot) in [https://github.com/dependabot/fetch-metadata/pull/214](https://github.com/dependabot/fetch-metadata/pull/214) - Bump [@​types/node](https://github.com/types/node) from 17.0.25 to 18.7.18 by [@​dependabot](https://github.com/dependabot) in [https://github.com/dependabot/fetch-metadata/pull/255](https://github.com/dependabot/fetch-metadata/pull/255) - Bump [@​typescript-eslint/parser](https://github.com/typescript-eslint/parser) from 5.20.0 to 5.38.0 by [@​dependabot](https://github.com/dependabot) in [https://github.com/dependabot/fetch-metadata/pull/254](https://github.com/dependabot/fetch-metadata/pull/254) - Bump eslint from 8.13.0 to 8.23.1 by [@​dependabot](https://github.com/dependabot) in [https://github.com/dependabot/fetch-metadata/pull/259](https://github.com/dependabot/fetch-metadata/pull/259) - Bump nock from 13.2.4 to 13.2.9 by [@​dependabot](https://github.com/dependabot) in [https://github.com/dependabot/fetch-metadata/pull/260](https://github.com/dependabot/fetch-metadata/pull/260) - Bump yargs and [@​types/yargs](https://github.com/types/yargs) by [@​dependabot](https://github.com/dependabot) in [https://github.com/dependabot/fetch-metadata/pull/261](https://github.com/dependabot/fetch-metadata/pull/261) - Bump eslint-plugin-promise from 6.0.0 to 6.0.1 by [@​dependabot](https://github.com/dependabot) in [https://github.com/dependabot/fetch-metadata/pull/263](https://github.com/dependabot/fetch-metadata/pull/263) - Bump dotenv from 16.0.0 to 16.0.2 by [@​dependabot](https://github.com/dependabot) in [https://github.com/dependabot/fetch-metadata/pull/262](https://github.com/dependabot/fetch-metadata/pull/262) - Bump [@​vercel/ncc](https://github.com/vercel/ncc) from 0.33.4 to 0.34.0 by [@​dependabot](https://github.com/dependabot) in [https://github.com/dependabot/fetch-metadata/pull/264](https://github.com/dependabot/fetch-metadata/pull/264) - Bump [@​actions/github](https://github.com/actions/github) from 5.0.1 to 5.0.3 by [@​dependabot](https://github.com/dependabot) in [https://github.com/dependabot/fetch-metadata/pull/265](https://github.com/dependabot/fetch-metadata/pull/265) - Bump ts-node from 10.7.0 to 10.9.1 by [@​dependabot](https://github.com/dependabot) in [https://github.com/dependabot/fetch-metadata/pull/266](https://github.com/dependabot/fetch-metadata/pull/266) - Bump typescript from 4.6.3 to 4.8.3 by [@​dependabot](https://github.com/dependabot) in [https://github.com/dependabot/fetch-metadata/pull/257](https://github.com/dependabot/fetch-metadata/pull/257) - Bump yaml from 2.0.1 to 2.1.1 by [@​dependabot](https://github.com/dependabot) in [https://github.com/dependabot/fetch-metadata/pull/258](https://github.com/dependabot/fetch-metadata/pull/258) #### New Contributors - [@​jeffwidman](https://github.com/jeffwidman) made their first contribution in [https://github.com/dependabot/fetch-metadata/pull/246](https://github.com/dependabot/fetch-metadata/pull/246) - [@​quinnjn](https://github.com/quinnjn) made their first contribution in [https://github.com/dependabot/fetch-metadata/pull/251](https://github.com/dependabot/fetch-metadata/pull/251) **Full Changelog**: dependabot/fetch-metadata@v1.3.3...v1.3.4 ### [`v1.3.3`](https://github.com/dependabot/fetch-metadata/releases/tag/v1.3.3) [Compare Source](https://github.com/dependabot/fetch-metadata/compare/v1.3.2...v1.3.3) #### What's Changed - action.yaml: fix skip-commit-verification quoting by [@​jsok](https://github.com/jsok) in [https://github.com/dependabot/fetch-metadata/pull/232](https://github.com/dependabot/fetch-metadata/pull/232) #### New Contributors - [@​jsok](https://github.com/jsok) made their first contribution in [https://github.com/dependabot/fetch-metadata/pull/232](https://github.com/dependabot/fetch-metadata/pull/232) **Full Changelog**: dependabot/fetch-metadata@v1.3.2...v1.3.3 ### [`v1.3.2`](https://github.com/dependabot/fetch-metadata/releases/tag/v1.3.2) [Compare Source](https://github.com/dependabot/fetch-metadata/compare/v1.3.1...v1.3.2) #### What's Changed - Update CODEOWNERS by [@​mattt](https://github.com/mattt) in [https://github.com/dependabot/fetch-metadata/pull/211](https://github.com/dependabot/fetch-metadata/pull/211) - Add 'skip-commit-verification' as an input for GitHub Enterprise Server users by [@​brrygrdn](https://github.com/brrygrdn) in [https://github.com/dependabot/fetch-metadata/pull/225](https://github.com/dependabot/fetch-metadata/pull/225) #### New Contributors - [@​mattt](https://github.com/mattt) made their first contribution in [https://github.com/dependabot/fetch-metadata/pull/211](https://github.com/dependabot/fetch-metadata/pull/211) **Full Changelog**: dependabot/fetch-metadata@v1.3.1...v1.3.2 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [x] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/ilkka/nisse). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi45Ny4xIiwidXBkYXRlZEluVmVyIjoiMzYuOTcuMSIsInRhcmdldEJyYW5jaCI6InRydW5rIn0=-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Over in
#360 (comment), I noticed that bash was complaining about this script:
bin/bump-version: line 9: ((: patch_level == 'major' || patch_level == 'minor' || patch_level == 'patch': syntax error: operand expected (error token is "'major' || patch_level == 'minor' || patch_level == 'patch'")
I started to dig into it, but the
while
loop isn't needed, thecase
statement felt unecessarily complex so I simplified it to use anif
statement.I also changed the argument from a flag-based argument to simple ordered argument, as again it seemed simpler and it matches the style of the bump version script over in
dependabot-core
so it's easier for engineers working across repos. If we later have additional flags, we can always switch it back later.Lastly, I found
patch_version
confusing given thatpatch
is a specific value that can be used, so I renamed it toversion_type
.