Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

moved symfony finder to dev-dependency #1452

Merged
merged 3 commits into from
Dec 14, 2017
Merged

Conversation

staabm
Copy link
Contributor

@staabm staabm commented Dec 14, 2017

Q A
Bug fix? No
New feature? No
BC breaks? No
Deprecations? No
Fixed tickets N/A

seems like the finder is not required for deployer itself, just for the build and phpcs.

Moved it to be a dev dependency so hopefully it wont be bundled with the deployer phar

@antonmedv
Copy link
Member

The Travis CI build failed

@staabm
Copy link
Contributor Author

staabm commented Dec 14, 2017

The travis build doesnt like the noted issue number in the changelog.

Is it required to create a separate issue or could I just drop the number from the changelog?

@antonmedv
Copy link
Member

Reference for a link [#1452] doesn't found in CHANGELOG.md
Add the next line to end of CHANGELOG.md file:
   [#1452]: https://github.com/deployphp/deployer/pull/1452

Take a look at the end of CHANGELOG.md

@staabm
Copy link
Contributor Author

staabm commented Dec 14, 2017

Ohh didnt read properly. Thx for the hint. Fixed.

@antonmedv antonmedv merged commit 7540038 into deployphp:master Dec 14, 2017
@staabm staabm deleted the patch-1 branch December 14, 2017 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants