Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hard shadows and make it more dark #23

Closed
TheVeryStarlk opened this issue Dec 26, 2018 · 2 comments
Closed

Add hard shadows and make it more dark #23

TheVeryStarlk opened this issue Dec 26, 2018 · 2 comments
Labels
enhancement New feature or request

Comments

@TheVeryStarlk
Copy link

No description provided.

@depressed-pho
Copy link
Owner

You don't like the edges of shadows being soft, right? Okay I made them a bit sharper. The problem is that the way we express shadows can't take account of distance between objects and the ground, but that's what determines the shapness of shadows as explained in this page: https://blog.demofox.org/2017/07/01/why-are-some-shadows-soft-and-other-shadows-hard/

As for darkness I took a careful balance of it and I'm not going to change it for now. In the future when the game provides a way to configure shaders in game, I will definitely make a settings screen to change various aspects of my shaders. Please bear with the status quo until then.

@depressed-pho
Copy link
Owner

A screenshot of the development version:
4221ad1b-140a-4e4f-9ab1-ac92bb3ec626

@depressed-pho depressed-pho added the enhancement New feature or request label Dec 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants