fix(autocomplete-valid): incomplete for invalid but safe values #4500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
autocomplete="text" incompletes Refs: #4492
WilcoFiers
previously requested changes
Jun 12, 2024
Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com>
straker
reviewed
Jun 17, 2024
| "fail": "The autocomplete attribute is incorrectly formatted" | ||
| "pass": "the autocomplete attribute is correctly formatted", | ||
| "fail": "the autocomplete attribute is incorrectly formatted", | ||
| "incomplete": "the autocomplete attribute has a non-standard value. Check whether any standard value could be used instead." |
There was a problem hiding this comment.
I struggled to understand what the meaning of this message was suppose to be from the recent suggestion. I hope this clarifies it but we can discuss if you want this changed @WilcoFiers
WilcoFiers
approved these changes
Jun 20, 2024
| @@ -5,7 +5,8 @@ | |||
| "impact": "serious", | |||
| "messages": { | |||
| "pass": "the autocomplete attribute is correctly formatted", | |||
| "fail": "the autocomplete attribute is incorrectly formatted" | |||
| "fail": "the autocomplete attribute is incorrectly formatted", | |||
| "incomplete": "check that this invalid autocomplete attribute does not necessary for accessibility" | |||
There was a problem hiding this comment.
Suggested change
| "incomplete": "check that this invalid autocomplete attribute does not necessary for accessibility" | |
| "incomplete": "check that this unknown autocomplete attribute does not necessary for accessibility" |
WilcoFiers
added a commit
that referenced
this pull request
Jul 29, 2024
## [4.10.0](v4.9.1...v4.10.0) (2024-07-29) ### Features - **new-rule:** summary elements must have an accessible name ([#4511](#4511)) ([0d8a99e](0d8a99e)), closes [#4510](#4510) ### Bug Fixes - **all-rules:** fix flakey all-rules firefox test ([#4467](#4467)) ([3f13aa1](3f13aa1)) - **aria-allowed-attr:** allow aria-multiline=false for element with contenteditable ([#4537](#4537)) ([f019068](f019068)) - **aria-allowed-attr:** allow aria-required=false when normally not allowed ([#4532](#4532)) ([2e242e1](2e242e1)) - **aria-prohibited-attr:** allow aria-label/ledby on decendants of widget ([#4541](#4541)) ([07c5d91](07c5d91)) - **aria-roledescription:** keep disabled with { runOnly: 'wcag2a' } ([#4526](#4526)) ([5b4cb9d](5b4cb9d)), closes [#4523](#4523) - **autocomplete-valid:** incomplete for invalid but safe values ([#4500](#4500)) ([e31a974](e31a974)), closes [#4492](#4492) - **build:** limit locales to valid files when using the --all-lang option ([#4486](#4486)) ([d3db593](d3db593)), closes [#4485](#4485) - colorio.js patch mocking CSS ([#4456](#4456)) ([3ef9353](3ef9353)), closes [#4400](#4400) - correct typos in texts ([#4499](#4499)) ([11fad59](11fad59)) - **landmark-unique:** follow spec, aside -> landmark ([#4469](#4469)) ([e32f803](e32f803)), closes [#4460](#4460) - **required-attr:** allow aria-valuetext on slider instead of valuenow ([#4518](#4518)) ([135898b](135898b)), closes [#4515](#4515) This PR was opened by a robot 🤖 🎉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4492
incomplete's some invalid, but safe to use, values forautocomplete. The common mistake in the original issue wasautocomplete="text"and I've added a few more I'd expect to see.Open to suggestions for more, or removing some of the ones below.
There are other ways to determine usage, GitHub is only one platform code is hosted for example. But it's a way to get a quick view into what's out there in production.