Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(standards): add html-elms spec #2333

Merged
merged 9 commits into from
Jul 9, 2020
Merged

feat(standards): add html-elms spec #2333

merged 9 commits into from
Jul 9, 2020

Conversation

straker
Copy link
Contributor

@straker straker commented Jun 29, 2020

Continued from #2325 to get a clean tree instead of a botched file merge of 34 file changes.

This table replaces some hardcoded values in our code and allows us to work on #1597 and #601 by allowing us to identify interactive content.

Replaces these values:

This will also allow us to replace svg-namespace-matches and html-namespace-matches with this table by looking up the element name in the table to get us 90% of the way there. Two elements such as a and svg belong to both tables, so we will have a special case for those.

There might be a few more but those were the ones I could find in a quick element search.

Just like we plan to do for the aria-attributes spec, we should create a commons helper that aggregates information from this table into useful forms, such as getting all elements that are of a certain content type.

Reviewer checks

Required fields, to be filled out by PR reviewer(s)

  • Follows the commit message policy, appropriate for next version
  • Code is reviewed for security

@straker straker requested a review from a team as a code owner June 29, 2020 23:21
lib/standards/html-aria.js Outdated Show resolved Hide resolved
lib/standards/html-aria.js Outdated Show resolved Hide resolved
lib/standards/html-aria.js Outdated Show resolved Hide resolved
lib/standards/html-aria.js Outdated Show resolved Hide resolved
lib/standards/html-aria.js Outdated Show resolved Hide resolved
@straker straker changed the title feat(standards): add html-aria spec feat(standards): add html-elms spec Jul 7, 2020
Copy link
Contributor

@WilcoFiers WilcoFiers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple more small points.

lib/standards/html-elms.js Outdated Show resolved Hide resolved
lib/standards/html-elms.js Outdated Show resolved Hide resolved
lib/standards/html-elms.js Outdated Show resolved Hide resolved
lib/standards/html-elms.js Outdated Show resolved Hide resolved
lib/standards/html-elms.js Outdated Show resolved Hide resolved
straker and others added 4 commits July 8, 2020 10:15
Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com>
Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com>
Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com>
@straker straker merged commit 1d6a888 into develop Jul 9, 2020
@straker straker deleted the standards-html-aria branch July 9, 2020 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants