-
Notifications
You must be signed in to change notification settings - Fork 776
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(standards): add html-elms spec #2333
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WilcoFiers
reviewed
Jun 30, 2020
WilcoFiers
previously requested changes
Jun 30, 2020
WilcoFiers
previously requested changes
Jul 1, 2020
WilcoFiers
reviewed
Jul 1, 2020
2 tasks
straker
changed the title
feat(standards): add html-aria spec
feat(standards): add html-elms spec
Jul 7, 2020
WilcoFiers
previously requested changes
Jul 8, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple more small points.
Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com>
Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com>
Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com>
WilcoFiers
approved these changes
Jul 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continued from #2325 to get a clean tree instead of a botched file merge of 34 file changes.
This table replaces some hardcoded values in our code and allows us to work on #1597 and #601 by allowing us to identify interactive content.
Replaces these values:
phrasingElements
in subtree-texthtmlTags
in is-html-element (which is why there are empty objects)possibleShadowRoots
in is-shadow-root.jssectioningElementSelector
in lookup-table.jsThis will also allow us to replace
svg-namespace-matches
andhtml-namespace-matches
with this table by looking up the element name in the table to get us 90% of the way there. Two elements such asa
andsvg
belong to both tables, so we will have a special case for those.There might be a few more but those were the ones I could find in a quick element search.
Just like we plan to do for the
aria-attributes
spec, we should create a commons helper that aggregates information from this table into useful forms, such as getting all elements that are of a certain content type.Reviewer checks
Required fields, to be filled out by PR reviewer(s)