Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(standards): add html-dom spec #2337

Closed
wants to merge 2 commits into from
Closed

Conversation

straker
Copy link
Contributor

@straker straker commented Jun 30, 2020

This table is new and not part of the previous lookup table. It replaces some hardcoded values in our code and allows us to work on #1597 and #601 by allowing us to identify interactive content.

Replaces these values:

There might be a few more but those were the ones I could find in a quick element search.

Just like we plan to do for the aria-attributes spec, we should create a commons helper that aggregates information from this table into useful forms, such as getting all elements that are of a certain content type.

Reviewer checks

Required fields, to be filled out by PR reviewer(s)

  • Follows the commit message policy, appropriate for next version
  • Code is reviewed for security

@straker straker requested a review from a team as a code owner June 30, 2020 16:49
@straker straker changed the title feat(standards): add html-dom standard feat(standards): add html-dom spec Jun 30, 2020
Copy link
Contributor

@WilcoFiers WilcoFiers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should combine this with the ARIA in HTML stuff. I don't think we should have axe architecture dictated by what spec something is in. There is a lot of overlap with the HTML in ARIA stuff, let's pull it together.

@straker
Copy link
Contributor Author

straker commented Jul 7, 2020

Merged in with #2333

@straker straker closed this Jul 7, 2020
@WilcoFiers WilcoFiers deleted the standards-html-dom branch January 30, 2023 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants