Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(scrollable-region-focusable): skip native controls #3862

Merged
merged 1 commit into from
Jan 20, 2023

Conversation

WilcoFiers
Copy link
Contributor

This rule isn't intended to test native controls. I'm honestly surprised that getScroll() doesn't cause select and textarea to be skipped like it does for input elements with lengthy texts. I suppose browsers did that to give the things their scrollbar, which input never gets.

Closes #3692, closes #3691, closes #3701

@WilcoFiers WilcoFiers requested a review from a team as a code owner January 19, 2023 17:49
@WilcoFiers WilcoFiers merged commit b0bdefa into develop Jan 20, 2023
@WilcoFiers WilcoFiers deleted the ignore-native-scrollables branch January 20, 2023 10:12
codeofdusk added a commit to microsoft/accessibility-insights-web that referenced this pull request Aug 1, 2023
…description, and promote scrollable-region-focusable (#6849)

This commit updates axe-core to its latest version, 4.7.2, from
4.6.3. It also
bumps the accessibility-insights-report package version. As part of the
axe-core update:

* The `aria-roledescription` rule has been deprecated
(dequelabs/axe-core#3649).
* `scrollable-region-focusable` axe-core rule failures have been
promoted from "needs review" to "serious" (manually removed from
explicit "needs review" but included automatically by axe-core), see
dequelabs/axe-core#3862 and dequelabs/axe-core#3939.
* `falsePositiveRemoval` introduced in
ed75fda has been removed as the
corresponding dequelabs/axe-core#3850 has been resolved.

Part of Feature 2086120 (internal access required to view).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants