Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

export declarations may only appear at top level of a module #61

Closed
johan-smits opened this issue Dec 22, 2021 · 2 comments · Fixed by #62
Closed

export declarations may only appear at top level of a module #61

johan-smits opened this issue Dec 22, 2021 · 2 comments · Fixed by #62

Comments

@johan-smits
Copy link

With version 2.29.1 the javascript fails to work with a normal asset pipeline. Caused by #60

export declarations may only appear at top level of a module.

I guess just the export needs to be removed?
@MrSerth MrSerth mentioned this issue Dec 22, 2021
Closed
@HADDADSOHAIB
Copy link

I just spent a whole day trying to solve this, no luck. a quick work around is to go back to v 2.20.1

shouichi added a commit to shouichi/administrate that referenced this issue Dec 28, 2021
@shouichi
Limit the highest momentjs-rails version to 2.20.1
4d137fd 
v2.29.1 causes "export declarations may only appear at top level of a
module" error.

See derekprior/momentjs-rails#61.
@shouichi shouichi mentioned this issue Dec 28, 2021
Merged
pablobm added a commit to pablobm/administrate that referenced this issue Dec 28, 2021
@pablobm
Avoid version that breaks CI with bad JS
2f697eb 
A new version of momentjs-rails was released on 2021-12-20. This
unfortunately contains some JS that browsers can't interpret
(specifically, an `export` declaration), breaking all JS in
Administrate. Other people are reporting this issue at
derekprior/momentjs-rails#61

Pinning the previous version of the gem appears to be the only solution
for now.
pablobm added a commit to pablobm/administrate that referenced this issue Dec 28, 2021
@pablobm
Avoid version that breaks CI with bad JS
2e71ff3 
A new version of momentjs-rails was released on 2021-12-20. This
unfortunately contains some JS that browsers can't interpret
(specifically, an `export` declaration), breaking all JS in
Administrate. Other people are reporting this issue at
derekprior/momentjs-rails#61

Pinning the previous version of the gem appears to be the only solution
for now.
pablobm pushed a commit to thoughtbot/administrate that referenced this issue Dec 28, 2021
@shouichi @pablobm
Limit the highest momentjs-rails version to 2.20.1
ceae954 
v2.29.1 causes "export declarations may only appear at top level of a
module" error.

See derekprior/momentjs-rails#61.
@ashkulz ashkulz mentioned this issue Dec 31, 2021
Merged
@derekprior
Copy link
Owner

Fixed with 2.29.1.1. Thanks @ashkulz

https://rubygems.org/gems/momentjs-rails/versions/2.29.1.1

@ashkulz ashkulz mentioned this issue Jul 25, 2022
Merged
KingTiger001 added a commit to KingTiger001/admin-Rails-project that referenced this issue Jan 15, 2023
@KingTiger001
Limit the highest momentjs-rails version to 2.20.1
084c9cf 
v2.29.1 causes "export declarations may only appear at top level of a
module" error.

See derekprior/momentjs-rails#61.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

replace MomentJS 2.29.1 assets with actual files
3 participants
@derekprior @johan-smits @HADDADSOHAIB