Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace MomentJS 2.29.4 assets with actual files #68

Merged
merged 1 commit into from
Jul 26, 2022
Merged

replace MomentJS 2.29.4 assets with actual files #68

merged 1 commit into from
Jul 26, 2022

Conversation

ashkulz
Copy link
Contributor

@ashkulz ashkulz commented Jul 25, 2022

This is the same thing that happened in #61 and I fixed via #62 🙈

@ashkulz
Copy link
Contributor Author

ashkulz commented Jul 25, 2022

@derekprior would appreciate your merging this and releasing 2.29.4.1 to RubyGems 👍

muruvetri
muruvetri approved these changes Jul 25, 2022
View reviewed changes
Copy link
Contributor

@muruvetri muruvetri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it will nice to have this check on unit-tests when I copied assests it didn't have UMD on my assests, That explains the reason for this issue.

@derekprior derekprior merged commit de473b8 into derekprior:main Jul 26, 2022
@derekprior
Copy link
Owner

Pushed new release.

@ashkulz
Copy link
Contributor Author

ashkulz commented Jul 27, 2022

Thanks, @derekprior!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@muruvetri muruvetri muruvetri approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ashkulz @derekprior @muruvetri